This repository was archived by the owner on Aug 3, 2022. It is now read-only.
Use TLS SNI extension with pyOpenSSL#43
Open
kimmok wants to merge 1 commit into
Open
Conversation
Use TLS SNI extension in the client, if pyOpenSSL is available. This fixes resource fetches to https servers that require the extension. These are typically cdn servers. Example of such server, without SNI: $ openssl s_client -connect cdn3.vox-cdn.com:443 CONNECTED(00000003) 140434795792032:error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure:s23_clnt.c:732: ... With SNI: $ openssl s_client -connect cdn3.vox-cdn.com:443 -servername cdn3.vox-cdn.com CONNECTED(00000003) depth=3 C = US, O = "The Go Daddy Group, Inc.", OU = Go Daddy Class 2 Certification Authority ....
|
Can you record HTTPS pages? I'm still getting SSL proxy error |
Author
|
Yeah. I had problems with some https sites (the ones requiring SNI), not all of them. So if you have problems with all HTTPS pages, you have a different problem :) I'm using chromium with --ignore-certificate-errors. Also mainly using it with --testing-fixed-http-port=$1 --testing-fixed-https-port=$2 , though I tried to test also with the dns spoofing . I don't have http or https proxies for the web-page-replay, though. I don't know if they work, and unfortunately I could not test if this patch breaks them or not.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use TLS SNI extension in the client, if pyOpenSSL is available.
This fixes resource fetches to https servers that require the
extension. These are typically cdn servers.
Example of such server, without SNI:
$ openssl s_client -connect cdn3.vox-cdn.com:443
CONNECTED(00000003)
140434795792032:error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure:s23_clnt.c:732:
...
With SNI:
$ openssl s_client -connect cdn3.vox-cdn.com:443 -servername cdn3.vox-cdn.com
CONNECTED(00000003)
depth=3 C = US, O = "The Go Daddy Group, Inc.", OU = Go Daddy Class 2
Certification Authority
....