Allow array params on notification messages#8
Merged
Conversation
Per the LSP notificationMessage spec, a notification's params may be either an array or an object (params?: array | object). BaseNotification typed params as dict | None, so it could not carry array params. Widen it to list | dict | None and document the type per spec. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
christiankissig
added a commit
that referenced
this pull request
Jul 7, 2026
Allow array params on notification messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
NotificationMessageper LSP 3.17 — Notification Message.The spec defines a notification as
Message+method: string+params?: array | object.BaseNotification(aliased asNotificationMessage) typedparamsasdict | None, so it could not carry array params, which the spec explicitly allows.Changes
BaseNotification.paramsfromdict | Nonetolist | dict | None.BaseNotificationper the spec (no response is sent back; params may be an array or an object).This is backward compatible — existing object (dict) params and the concrete notification subclasses are unaffected.
Testing
methodrequired.poetry run pytest(59 passed),ruff check,ruff format --check, andmypyall clean.Note: the request message (
BaseRequest) has the sameparams?: array | objectshape in the spec and is still typeddict | None; I left it untouched to keep this PR scoped to notifications — happy to widen it in a follow-up if desired.🤖 Generated with Claude Code