Add LanguageKind identifiers for TextDocumentItem#6
Merged
Conversation
The LSP TextDocumentItem spec types languageId as a free-form string but documents a table of recognised language identifiers (abap, c, cpp, python, typescript, ...). Add a LanguageKind str enum covering those identifiers and type languageId as `LanguageKind | str` so callers get the documented constants while custom identifiers remain valid. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
christiankissig
added a commit
that referenced
this pull request
Jul 7, 2026
Add LanguageKind identifiers for TextDocumentItem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
languageIdper LSP 3.17 — TextDocumentItem.The spec types
languageIdas a free-formstringbut documents a table of recognised language identifiers (abap,c,cpp,python,typescript,git-commit, …). The model previously typed it as a barestr, giving callers no reference for the documented values.Changes
LanguageKindstring enum covering every identifier in the spec's table (including the dualscss/sassandgit-commit/git-rebaseentries).TextDocumentItem.languageIdasLanguageKind | str, so:LanguageKindmember is type-checked and round-trips,stringtype).TextDocumentItem/LanguageKind; exportLanguageKindfromlsp_client.Testing
LanguageKindmember, known string, custom string, and a JSON wire round-trip (serialises to the bare identifier).poetry run pytest(51 passed),ruff check,ruff format --check, andmypyall clean.🤖 Generated with Claude Code