Constrain Position offsets to the LSP uinteger type#5
Merged
Conversation
Per the LSP 3.17 Range/Position spec, line and character offsets are uinteger (non-negative, 0..2^31-1), not signed integers. Add a uinteger type alias and apply it to Position so negative or out-of-range offsets are rejected at validation time. Also document Position/Range per spec. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
christiankissig
added a commit
that referenced
this pull request
Jul 7, 2026
Constrain Position offsets to the LSP uinteger type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
Range/Positionin the format mandated by LSP 3.17 — Range.The spec types
Position.lineandPosition.characterasuinteger— a non-negative integer bounded to[0, 2^31 - 1]— not a signedint. The previous models used plainint, which silently accepted negative offsets.Changes
uintegertype alias (Annotated[int, Field(ge=0, le=2147483647)]) per the spec's base type.Position.line/Position.character, so negative or out-of-range offsets are rejected at validation time.PositionandRange(zero-based offsets, exclusive end, empty range = single position, encoding-dependentcharacterunit).Testing
Rangestructure and nested-position validation.poetry run pytest(46 passed),ruff check,ruff format --check, andmypyall clean.🤖 Generated with Claude Code