Add workDoneProgress protocol support#2
Merged
Conversation
Implements the Work Done Progress data types from LSP 3.17: - WorkDoneProgressBegin / Report / End — the `value` payloads carried by `$/progress` notifications, with a `kind` discriminator. - WorkDoneProgressOptions — server capability marker. - WorkDoneProgressCreateRequest (`window/workDoneProgress/create`) and WorkDoneProgressCancelNotification (`window/workDoneProgress/cancel`), plus their token params. - ProgressToken alias (int | str) shared by progress/work-done params. Exports the new types from the package root and adds protocol tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
christiankissig
added a commit
that referenced
this pull request
Jul 7, 2026
Implements the Work Done Progress data types from LSP 3.17: - WorkDoneProgressBegin / Report / End — the `value` payloads carried by `$/progress` notifications, with a `kind` discriminator. - WorkDoneProgressOptions — server capability marker. - WorkDoneProgressCreateRequest (`window/workDoneProgress/create`) and WorkDoneProgressCancelNotification (`window/workDoneProgress/cancel`), plus their token params. - ProgressToken alias (int | str) shared by progress/work-done params. Exports the new types from the package root and adds protocol tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Work Done Progress data types from LSP 3.17 to
protocol.py:WorkDoneProgressBegin/WorkDoneProgressReport/WorkDoneProgressEnd— thevaluepayloads carried by$/progressnotifications, each with a literalkinddiscriminator (begin/report/end).WorkDoneProgressOptions— theworkDoneProgress?: booleanserver capability marker.WorkDoneProgressCreateRequest(window/workDoneProgress/create, server→client) andWorkDoneProgressCancelNotification(window/workDoneProgress/cancel, client→server), with their…Paramstoken models.ProgressTokenalias (int | str), now shared byProgressParamsand the new params.The pre-existing
WorkDoneProgressParamsmixin (workDoneToken) is now also exported from the package root.All new types follow the existing conventions:
BaseModelpayloads,BaseRequest/BaseNotificationsubclasses that hard-codemethodin__init__and accept a typedparamsmodel (dumped withexclude_none=True), exported via__init__.py.Testing
ruff check,ruff format --check,mypy, and fullpytest(26 passed) all pass locally.🤖 Generated with Claude Code