Export ProgressToken from the package root#12
Merged
Conversation
ProgressToken is defined in protocol.py and is part of the public surface (ProgressParams, WorkDoneProgressCreateParams and WorkDoneProgressCancelParams all expose it), but it was missing from the package __init__, so `from lsp_client import ProgressToken` failed. Add it to the imports and __all__. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
christiankissig
added a commit
that referenced
this pull request
Jul 7, 2026
Export ProgressToken from the package root
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProgressTokenis defined inlsp_client/protocol.pyand is part of the public API —ProgressParams,WorkDoneProgressCreateParams, andWorkDoneProgressCancelParamsall type theirtokenfield with it — but it was missing from the package__init__. As a resultfrom lsp_client import ProgressTokenraisedImportError.This adds
ProgressTokento both the__init__imports and__all__, filling a gap left by the recent server-capabilities expansion.Why
Downstream code (e.g. the Isabelle LSP client) needs to import
ProgressTokento annotate work-done-progress handling. Without this export it has to re-declare the alias locally, duplicating a spec type.Test plan
ruff checkcleanpytest— 75 passed🤖 Generated with Claude Code