-
Notifications
You must be signed in to change notification settings - Fork 12
OCD-5292 | Navigation and Active State Handling #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattystank
wants to merge
9
commits into
chpladmin:staging
Choose a base branch
from
mattystank:OCD-5292
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fa4ae96
feat: Allow navigating by clicking anywhere in nav menu item row
mattystank d983501
feat!: Enhance navigation components with full bar selection, active …
mattystank 76d9f34
fix: Make admin menu link rows fully clickable with navigation
mattystank 965167a
fix: Remove AngularJS dependencies from admin menu link item
mattystank bb0a7ce
refactor: Simplify navigation components by removing AngularJS depend…
mattystank a4a5322
fix: Destructure analytics from useAnalyticsContext for clarity
mattystank f79d079
Merge remote-tracking branch 'upstream/staging' into OCD-5292
mattystank 545fddd
feat: add HashContext and refactor components to use hash-based navig…
mattystank 1899902
Merge remote-tracking branch 'upstream/staging' into OCD-5292
mattystank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import React, { | ||
| createContext, | ||
| useContext, | ||
| useEffect, | ||
| useState, | ||
| } from 'react'; | ||
|
|
||
| const HashContext = createContext({ | ||
| currentHash: '', | ||
| }); | ||
| HashContext.displayName = 'hash-context'; | ||
|
|
||
| function HashProvider(props) { | ||
| const [currentHash, setCurrentHash] = useState(window.location.hash); | ||
|
|
||
| useEffect(() => { | ||
| const handleHashChange = () => setCurrentHash(window.location.hash); | ||
| window.addEventListener('hashchange', handleHashChange); | ||
| return () => window.removeEventListener('hashchange', handleHashChange); | ||
| }, []); | ||
|
|
||
| const data = { | ||
| currentHash, | ||
| }; | ||
|
|
||
| /* eslint-disable react/jsx-props-no-spreading */ | ||
| return <HashContext.Provider value={data} {...props} />; | ||
| /* eslint-enable react/jsx-props-no-spreading */ | ||
| } | ||
|
|
||
| HashProvider.propTypes = { | ||
| }; | ||
|
|
||
| function useHashContext() { | ||
| return useContext(HashContext); | ||
| } | ||
|
|
||
| export { | ||
| HashContext, HashProvider, useHashContext, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.