Skip to content

OCD-5295 | Refactors to the filter and search components#1511

Open
mattystank wants to merge 51 commits into
chpladmin:stagingfrom
mattystank:OCD-5295
Open

OCD-5295 | Refactors to the filter and search components#1511
mattystank wants to merge 51 commits into
chpladmin:stagingfrom
mattystank:OCD-5295

Conversation

@mattystank

@mattystank mattystank commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This pull request focuses on standardizing the use of the palette and theme objects from the themes module for consistent styling across the application. It also introduces several UI and usability improvements, especially around filter panels and download buttons, and adds better support for responsive layouts and embedded views. Below are the most important changes grouped by theme:

Theming and Styling Consistency

  • Replaced hardcoded color values with references to palette and theme throughout multiple components, including api-key-registration.jsx, change-request.jsx, change-requests-view.jsx, developer-view.jsx, filter-chips.jsx, and filter-panel.jsx, ensuring consistent color usage and easier theme management. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

  • Updated filter panel and filter chips components to use palette for backgrounds and borders, and improved their responsive layout and z-index handling. [1] [2] [3] [4] [5] [6]

Filter Panel and Search Bar Enhancements

  • Improved the filter panel's anchor and width calculations for better alignment with the search bar, changed the advanced search button color, and adjusted the panel's responsive behavior and border logic. [1] [2] [3] [4]

  • Enhanced the filter search bar's responsive styles to improve usability on small screens. [1] [2]

Download Listings and Button Group Improvements

  • Refactored the download listings component to use new button group and button styles, improving responsiveness and accessibility on smaller screens. Added new CSS classes and adjusted button properties for better layout and appearance. [1] [2] [3]

Change Requests Component Updates

  • Added an embedded prop to ChplChangeRequestsView and ChplChangeRequests for better control over layout and sticky behavior when used in different contexts. Updated prop types accordingly. [1] [2] [3] [4] [5] [6] [7] [8]

Minor UI Tweaks

  • Adjusted padding, margin, and button size for the certification status legend's info button for a more compact appearance.

These changes collectively improve the application's maintainability, visual consistency, and user experience across devices and embedded contexts.

…aying results

- Replaced table structures with card components in inactive certificates, real world testing, SED, and SVAP search views.
- Updated sorting functionality to use ChplSortControls.
- Enhanced loading indicators with CircularProgress.
- Improved layout and styling for better responsiveness and user experience.
- Added a new background color to the theme palette for better visual distinction.

[#OCD-5295]
…y components for consistent layout

- Removed redundant header and body styles from various search views (Corrective Action, Decertified Products, Decision Support Interventions, Inactive Certificates, Real World Testing, SED, SVAP).
- Integrated ChplPageHeader and ChplPageBody components to standardize the presentation of page titles and subtitles across search pages.
- Updated subtitles to provide detailed descriptions and context for each search page.
- Adjusted layout and styling for better responsiveness and visual consistency.

[#OCD-5295]
- Added informational headers and descriptive content to all 9 collection/search pages
- Maintained card-based result display using ChplSearchResultCard
- Updated component props to use cardTitle/cardTitleValue naming convention

[#OCD-5295]

@andlar andlar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a draft, and I only got about 40% of the way through it while waiting on other things to happen, but wanted to put my comments out there while I was thinking of them

Comment thread src/app/components/util/pagination.jsx Outdated
Comment thread src/app/components/util/chpl-sort-controls.jsx Outdated
Comment thread src/app/pages/search/banned-developers/banned-developers-view.jsx Outdated
Comment thread src/app/pages/search/banned-developers/banned-developers-view.jsx Outdated
Comment thread src/app/pages/search/corrective-action/corrective-action-view.jsx Outdated
Comment thread src/app/pages/search/corrective-action/corrective-action-view.jsx Outdated
mattystank added 14 commits June 1, 2026 15:53
…omponents for consistent layout across all search pages

[#OCD-5295]
…rch result display across various views

[#OCD-5295]
…raphy

- Removed makeStyles and associated styles from multiple search view components.
- Updated text elements to use Typography for better consistency and readability.
- Simplified JSX structure by removing unnecessary divs and classes.
- Ensured all components maintain functionality while enhancing visual presentation.

[#OCD-5295]
…iews for enhanced certification status display

[#OCD-5295]
…out in ChplSearchResultCard and ChplSearchResultControls

[#OCD-5295]
… improve button padding in listing service

[#OCD-5295]
@mattystank mattystank changed the title Ocd 5295 OCD-5295 Jun 4, 2026
@mattystank mattystank marked this pull request as ready for review June 4, 2026 19:52
@mattystank mattystank changed the title OCD-5295 OCD-5295 | Refactors to the filter and search components Jun 8, 2026
Comment thread src/app/components/change-request/change-requests-view.jsx Outdated
Comment thread src/app/components/download-listings/download-listings.jsx Outdated
Comment thread src/app/components/util/chpl-loading-cards.jsx Outdated
Comment thread src/app/components/util/chpl-loading-cards.jsx Outdated
Comment thread src/app/components/util/pagination.jsx
Comment thread src/app/pages/search/banned-developers/banned-developers-view.jsx
Comment thread src/app/pages/search/decertified-products/decertified-products-view.jsx Outdated
Comment thread src/app/components/util/pagination.jsx Outdated
@mattystank mattystank requested a review from andlar June 30, 2026 17:26
Comment thread src/app/components/change-request/change-requests-view.jsx Outdated
Comment thread src/app/components/jobs/system-job-types-view.jsx
Comment thread src/app/pages/search/svap/svap-view.jsx Outdated
Comment thread src/app/pages/search/sed/sed-view.jsx Outdated
…update main content structure in various views

[#OCD-5295]
Comment thread src/app/components/util/chpl-page-body.jsx Outdated
Comment thread src/app/components/change-request/change-requests-view.jsx Outdated
Comment thread src/app/components/jobs/system-job-types-view.jsx Outdated
Comment thread src/app/components/util/chpl-search-result-card.jsx Outdated
Comment thread src/app/pages/search/banned-developers/banned-developers-view.jsx Outdated
…dy; enhance flex styling in ChplSearchResultCard

[#OCD-5295]
@mattystank mattystank requested a review from andlar July 1, 2026 20:26
Comment thread src/app/components/change-request/change-requests-view.jsx
Comment thread src/app/pages/search/listings/listings-view.jsx
andlar
andlar previously approved these changes Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants