Skip to content

Add time-to-event ML-UMR support#2

Open
choxos wants to merge 1 commit into
mainfrom
release/v0.2.0
Open

Add time-to-event ML-UMR support#2
choxos wants to merge 1 commit into
mainfrom
release/v0.2.0

Conversation

@choxos

@choxos choxos commented Jun 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • add survival/time-to-event ML-UMR models, data setup, prediction, and diagnostics
  • add bundled example data and survival-focused tests
  • update documentation sources and package metadata for v0.2.0

Validation

  • testthat::test_local(".", reporter = testthat::SummaryReporter()) passed with Stan sampling warnings from short test fits

Note: rendered vignette HTML, figures, and build outputs are intentionally not included.

Copilot AI review requested due to automatic review settings June 1, 2026 18:35
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 191 files, which is 41 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 63443598-d4e0-4eea-a6ed-494195bc8af4

📥 Commits

Reviewing files that changed from the base of the PR and between 17eb0b4 and e1aafd3.

⛔ Files ignored due to path filters (4)
  • data-raw/dental_caries_rct.xlsx is excluded by !**/*.xlsx
  • data-raw/fimpact_10y.xlsx is excluded by !**/*.xlsx
  • man/figures/logo.png is excluded by !**/*.png
  • man/figures/logo.svg is excluded by !**/*.svg
📒 Files selected for processing (191)
  • .Rbuildignore
  • .gitattributes
  • .github/.gitignore
  • .github/workflows/pkgdown.yaml
  • .gitignore
  • .lintr
  • DESCRIPTION
  • NAMESPACE
  • NEWS.md
  • R/backend_cmdstanr.R
  • R/conditional_effects.R
  • R/data.R
  • R/data_setup.R
  • R/family_config.R
  • R/integration.R
  • R/link_functions.R
  • R/mlumr-package.R
  • R/mlumr.R
  • R/mlumr_class.R
  • R/mspline.R
  • R/naive.R
  • R/numerical_guards.R
  • R/plot.R
  • R/predict.R
  • R/prior_sensitivity.R
  • R/prior_summary.R
  • R/priors.R
  • R/stanmodels.R
  • R/stc.R
  • R/survival.R
  • R/utils.R
  • README.md
  • _pkgdown.yml
  • cran-comments.md
  • data-raw/fimpact_README.rtf
  • data-raw/harmonize_columns.R
  • data-raw/prepare_multinma_subsets.R
  • data-raw/simulate_external_data.R
  • data/caries_agd.rda
  • data/caries_ipd.rda
  • data/ndmm_agd.rda
  • data/ndmm_agd_covs.rda
  • data/ndmm_ipd.rda
  • data/psoriasis_agd.rda
  • data/psoriasis_ipd.rda
  • data/shoulder_agd.rda
  • data/shoulder_ipd.rda
  • inst/REFERENCES.bib
  • inst/stan/include/binary_functions.stan
  • inst/stan/include/survival_aux_hyperparameters.stan
  • inst/stan/include/survival_functions.stan
  • inst/stan/include/survival_mspline_functions.stan
  • inst/stan/mlumr_binary_relaxed.stan
  • inst/stan/mlumr_binary_spfa.stan
  • inst/stan/mlumr_normal_relaxed.stan
  • inst/stan/mlumr_normal_spfa.stan
  • inst/stan/mlumr_poisson_relaxed.stan
  • inst/stan/mlumr_poisson_spfa.stan
  • inst/stan/mlumr_survival_mspline_relaxed.stan
  • inst/stan/mlumr_survival_mspline_spfa.stan
  • inst/stan/mlumr_survival_relaxed.stan
  • inst/stan/mlumr_survival_spfa.stan
  • man/add_integration.Rd
  • man/caries_agd.Rd
  • man/caries_ipd.Rd
  • man/check_integration.Rd
  • man/conditional_effects.Rd
  • man/conditional_predict.Rd
  • man/default_priors.Rd
  • man/dot-build_arm_summary.Rd
  • man/dot-build_mspline_basis.Rd
  • man/dot-build_stan_data_survival.Rd
  • man/dot-clamp_cor.Rd
  • man/dot-conditional_predict_survival.Rd
  • man/dot-eval_basis.Rd
  • man/dot-get_surv_data.Rd
  • man/dot-marginal_effects_survival.Rd
  • man/dot-mlumr_build_stan_data.Rd
  • man/dot-mlumr_center_covariates.Rd
  • man/dot-mlumr_prior_metadata.Rd
  • man/dot-mlumr_qr_design.Rd
  • man/dot-mspline_constant_hazard.Rd
  • man/dot-naive_survival.Rd
  • man/dot-predict_survival.Rd
  • man/dot-r_log_surv.Rd
  • man/dot-relaxed_index_note.Rd
  • man/dot-rw1_prior_weights.Rd
  • man/dot-set_ipd_survival.Rd
  • man/dot-softmax.Rd
  • man/dot-stc_flexsurv_dist.Rd
  • man/dot-stc_survival.Rd
  • man/dot-stc_survival_point.Rd
  • man/dot-surv_eval_curve.Rd
  • man/dot-surv_median_from_draws.Rd
  • man/dot-survival_distribution_info.Rd
  • man/dot-validate_stc_survival_right_censored.Rd
  • man/dot-validate_survival_controls.Rd
  • man/dot-validate_survival_prediction_times.Rd
  • man/dot-validate_survival_times.Rd
  • man/make_knots.Rd
  • man/marginal_effects.Rd
  • man/mlumr-numerical-guards.Rd
  • man/mlumr-package.Rd
  • man/mlumr.Rd
  • man/naive.Rd
  • man/ndmm_agd.Rd
  • man/ndmm_agd_covs.Rd
  • man/ndmm_ipd.Rd
  • man/plot.mlumr_conditional_effects.Rd
  • man/plot.mlumr_marginal_effects.Rd
  • man/plot.mlumr_prediction.Rd
  • man/plot_prior_posterior.Rd
  • man/predict.mlumr_fit.Rd
  • man/prior_cauchy.Rd
  • man/prior_normal.Rd
  • man/prior_sensitivity.Rd
  • man/psoriasis_agd.Rd
  • man/psoriasis_ipd.Rd
  • man/set_agd_surv.Rd
  • man/set_ipd.Rd
  • man/shoulder_agd.Rd
  • man/shoulder_ipd.Rd
  • man/stc.Rd
  • src/RcppExports.cpp
  • src/stanExports_mlumr_binary_relaxed.cc
  • src/stanExports_mlumr_binary_relaxed.h
  • src/stanExports_mlumr_binary_spfa.cc
  • src/stanExports_mlumr_binary_spfa.h
  • src/stanExports_mlumr_normal_relaxed.cc
  • src/stanExports_mlumr_normal_relaxed.h
  • src/stanExports_mlumr_normal_spfa.cc
  • src/stanExports_mlumr_normal_spfa.h
  • src/stanExports_mlumr_poisson_relaxed.cc
  • src/stanExports_mlumr_poisson_relaxed.h
  • src/stanExports_mlumr_poisson_spfa.cc
  • src/stanExports_mlumr_poisson_spfa.h
  • src/stanExports_mlumr_survival_mspline_relaxed.cc
  • src/stanExports_mlumr_survival_mspline_relaxed.h
  • src/stanExports_mlumr_survival_mspline_spfa.cc
  • src/stanExports_mlumr_survival_mspline_spfa.h
  • src/stanExports_mlumr_survival_relaxed.cc
  • src/stanExports_mlumr_survival_relaxed.h
  • src/stanExports_mlumr_survival_spfa.cc
  • src/stanExports_mlumr_survival_spfa.h
  • tests/testthat/helper-survival.R
  • tests/testthat/test-conditional.R
  • tests/testthat/test-data_setup.R
  • tests/testthat/test-diagnostics.R
  • tests/testthat/test-engine.R
  • tests/testthat/test-integration.R
  • tests/testthat/test-loo_waic.R
  • tests/testthat/test-mlumr-validation.R
  • tests/testthat/test-mlumr.R
  • tests/testthat/test-mspline.R
  • tests/testthat/test-naive.R
  • tests/testthat/test-plot.R
  • tests/testthat/test-relaxed-prior-comparator.R
  • tests/testthat/test-stc.R
  • tests/testthat/test-survival-armfast-equivalence.R
  • tests/testthat/test-survival-data.R
  • tests/testthat/test-survival-fit.R
  • tests/testthat/test-survival-likelihood.R
  • tests/testthat/test-survival-naive-stc.R
  • tests/testthat/test-survival-predict-format.R
  • tests/testthat/test-survival-predict.R
  • vignettes/binary-outcomes.Rmd.orig
  • vignettes/binary-outcomes.html
  • vignettes/binary-outcomes.html.asis
  • vignettes/children/setup.R
  • vignettes/choosing-a-method.Rmd.orig
  • vignettes/choosing-a-method.html
  • vignettes/choosing-a-method.html.asis
  • vignettes/continuous-outcomes.Rmd.orig
  • vignettes/continuous-outcomes.html
  • vignettes/continuous-outcomes.html.asis
  • vignettes/count-outcomes.Rmd.orig
  • vignettes/count-outcomes.html
  • vignettes/count-outcomes.html.asis
  • vignettes/data-preparation.Rmd
  • vignettes/fitting-and-diagnostics.Rmd.orig
  • vignettes/fitting-and-diagnostics.html
  • vignettes/fitting-and-diagnostics.html.asis
  • vignettes/introduction.Rmd
  • vignettes/mlumr-models.Rmd
  • vignettes/model-comparison.Rmd
  • vignettes/precompile.R
  • vignettes/stc-and-naive.Rmd
  • vignettes/survival-outcomes.Rmd.orig
  • vignettes/survival-outcomes.html
  • vignettes/survival-outcomes.html.asis
  • vignettes/worked-example.Rmd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/v0.2.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@choxos

choxos commented Jun 1, 2026

Copy link
Copy Markdown
Owner Author

Closing for now. The release/v0.2.0 branch will remain available, but this PR should not be reviewed or merged yet.

@choxos choxos closed this Jun 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 157 out of 175 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 157 out of 175 changed files in this pull request and generated no new comments.

@choxos choxos force-pushed the release/v0.2.0 branch 9 times, most recently from 9f0cfa1 to e1aafd3 Compare June 7, 2026 13:40
@choxos choxos force-pushed the release/v0.2.0 branch 8 times, most recently from c767279 to 01ce414 Compare June 19, 2026 17:24
@choxos choxos force-pushed the release/v0.2.0 branch 14 times, most recently from a29167e to d4d54b3 Compare June 23, 2026 02:39
…: set_agd_surv(), make_knots(), survival predict() (survival/hazard/cumhaz/rmst/median/loghr), naive Cox + flexsurv STC, four Stan models (parametric + M-spline, SPFA/relaxed). Relaxed prior_beta_comparator across families; GLM-form likelihoods; precompiled vignettes; bundled example data. Build/CI hygiene (.Rbuildignore, .gitattributes, pkgdown article slugs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants