fix(dns): use record_id filter for get_dns_settings, not nameserver#194
Merged
Conversation
get_dns_settings accepts an optional record_id to narrow the result to a single record; the read slice had wired a non-existent nameserver parameter instead. Rename the flag --nameserver -> --record-id and the wire parameter nameserver -> record_id, matching the KAS contract and the captured request fixtures. nameserver is a real KAS key but belongs to reset_dns_settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dns listexposed a--nameserverflag and sent anameserverparameter thatget_dns_settingsdoes not accept. The KAS contract (and the captured request fixtures) take an optionalrecord_idto narrow the result to a single record.--nameserver→--record-id, wire paramnameserver→record_idget_dns_settingssingle-record fixture wired into a mapping testnameserveris a real KAS key, but forreset_dns_settings, notget_dns_settings