feat(directoryprotection): write endpoints — add / update / delete#193
Merged
Conversation
Wire add/update/delete_directoryprotection. A protection entry is identified by the (path, user) pair taken as two positional args. update and delete are gated by the #109 confirmation prompt; add is not. No directory_new_password split — update reuses directory_password — and update is sparse (only Changed flags sent). Scalar single-user form only; the KAS array form is deliberately not modelled. Closes #123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire
add_directoryprotection/update_directoryprotection/delete_directoryprotection(#123, #13 write slice).A protection entry is identified by the
(path, user)pair, taken as two positional args (add|update|delete <path> <user>).updateanddeleteare gated by the #109 confirmation prompt;addis not. No_new_passwordsplit —updatereusesdirectory_password— andupdateis sparse (only cobra-Changed flags sent). Scalar single-user form only; the documented KAS array form (multiple users/passwords per call) is deliberately not modelled since the array wire-encoding is uncaptured.Closes #123