-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(naming): drop legacy 'mothership' label #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,11 +19,11 @@ export class RegistryClient { | |
| */ | ||
| buildServiceInfo() { | ||
| return { | ||
| service: 'chittyid-mothership', | ||
| name: 'ChittyID Mothership', | ||
| service: 'chittyid', | ||
| name: 'ChittyID', | ||
| version: '2.0.0', | ||
| description: 'Identity management system with hardened security pipeline', | ||
| endpoint: 'https://chittyid-mothership.chitty.workers.dev', | ||
| endpoint: 'https://chittyid.chitty.workers.dev', | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
With the current worker config ( Useful? React with 👍 / 👎.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in #22 (commit 8236bb6): endpoint now reads from env.CHITTYID_SERVICE_URL / SERVICE_PUBLIC_URL, falling back to https://id.chitty.cc. No hardcoded workers.dev URL. |
||
| domain: 'https://id.chitty.cc', | ||
| health: '/api/health', | ||
| priority: 1, | ||
|
|
@@ -50,7 +50,7 @@ export class RegistryClient { | |
| ] | ||
| }, | ||
| registeredAt: new Date().toISOString(), | ||
| registeredBy: 'chittyid-mothership-deployment' | ||
| registeredBy: 'chittyid-deployment' | ||
| }; | ||
| } | ||
|
|
||
|
|
@@ -104,7 +104,7 @@ export class RegistryClient { | |
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'X-ChittyOS-Service': 'chittyid-mothership', | ||
| 'X-ChittyOS-Service': 'chittyid', | ||
| 'X-ChittyOS-Version': '2.0.0' | ||
| }, | ||
| body: JSON.stringify(this.serviceInfo) | ||
|
|
@@ -166,7 +166,7 @@ export class RegistryClient { | |
| method: 'PUT', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'X-ChittyOS-Service': 'chittyid-mothership' | ||
| 'X-ChittyOS-Service': 'chittyid' | ||
| }, | ||
| body: JSON.stringify({ | ||
| status, | ||
|
|
@@ -198,7 +198,7 @@ export class RegistryClient { | |
| */ | ||
| async getHealthStatus() { | ||
| try { | ||
| const response = await fetch('https://chittyid-mothership.chitty.workers.dev/api/health'); | ||
| const response = await fetch('https://chittyid.chitty.workers.dev/api/health'); | ||
| if (response.ok) { | ||
| return await response.json(); | ||
| } | ||
|
|
@@ -239,7 +239,7 @@ export class RegistryClient { | |
| const response = await fetch(`${registration.registry}/api/services/${registration.registrationId}`, { | ||
| method: 'DELETE', | ||
| headers: { | ||
| 'X-ChittyOS-Service': 'chittyid-mothership' | ||
| 'X-ChittyOS-Service': 'chittyid' | ||
| } | ||
| }); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
NOTION_SYNC_WORKER_URLis not set, the monitor now probesnotion-sync.chittyid.workers.dev; in a workers.dev URL the segment after the worker name is the Cloudflare account subdomain, so renaming the ChittyID service label does not move the separatenotion-syncworker from the existingchittyid-mothershipsubdomain. This default will make the health checks report the NotionSync worker as unreachable unless every environment overrides it.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #22 (commit 8236bb6): NOTION_SYNC_WORKER_URL is now required; script fails fast with a clear error otherwise. No wrangler config in this repo deploys notion-sync, so guessing a canonical URL would be wrong (the worker may be dead code worth removing separately).