alu: guard FN_ROR in shiftReverse behind useZbb parameter - #3804
Open
lakshhnaa wants to merge 1 commit into
Open
alu: guard FN_ROR in shiftReverse behind useZbb parameter#3804lakshhnaa wants to merge 1 commit into
lakshhnaa wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes residual logic in shin mux when useZbb=false.
The shiftReverse companion object method unconditionally included FN_ROR
in the isOneOf check, generating a dead comparator in the synthesized
netlist even when useZbb=false.
This PR inlines the shift-input mux condition directly into class ALU,
guarding FN_ROR behind coreParams.useZbb and FN_BEXT behind coreParams.useZbs,
consistent with the guards already present in the output MuxLookup.
No functional change when useZbb=true. Eliminates one dead 5-bit comparator
when useZbb=false.
Closes #3784