Create pending memberships when a member chooses "in person" on the payment screen - #2222
Draft
jim wants to merge 3 commits into
Draft
Create pending memberships when a member chooses "in person" on the payment screen#2222jim wants to merge 3 commits into
jim wants to merge 3 commits into
Conversation
jim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2168 by resolving a gap in how we were modeling the membership signup and renewal process. After a member completed renewal "in person" (#skip), no membership record was created, so the "your membership expired" banner never cleared. Fixing that surfaced two follow-on issues — how staff finish those renewals, and a payment double-charge — which this branch also addresses.