Refactor item status code and add to item search page - #2220
Open
jim wants to merge 1 commit into
Open
Conversation
Consolidates most of the status display and search code into a single file and names a concept that was always present: borrow status. Creates two new helper methods to make working with the statuses in view clearer. we know have item_status_label, member_item_status_label, and borrow_status_label.
phinze
approved these changes
Aug 3, 2026
phinze
left a comment
Contributor
There was a problem hiding this comment.
Great cleanup! Separating borrow status from item status makes everything a lot clearer.
| </td> | ||
| <td> | ||
| <%= item.status.humanize %> | ||
| <td class="no-wrap"> |
Contributor
There was a problem hiding this comment.
Tiny thing: this no-wrap doesn't actually attach. The only rule for it is .items-search th.no-wrap in admin.scss, so a td slips right past. Adding td.no-wrap to that selector should do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
item_status_label,member_item_status_label, andborrow_status_label.