Skip to content

fix(docs): avoid duplicate background warning#1214

Merged
chhoumann merged 1 commit into
masterfrom
fix/docs-background-warning
May 27, 2026
Merged

fix(docs): avoid duplicate background warning#1214
chhoumann merged 1 commit into
masterfrom
fix/docs-background-warning

Conversation

@chhoumann
Copy link
Copy Markdown
Owner

@chhoumann chhoumann commented May 27, 2026

Avoid the duplicate background warning in the docs homepage CSS.

The preview sidebar used a plain background fallback followed by a color-mix() enhancement in the same rule, which triggered an unexpected duplicate property warning. This keeps the fallback as the base declaration and moves the enhanced color into an @supports block so unsupported browsers still get the fallback while supported browsers apply the mixed background.

Verification:

  • bun run build from docs/
  • Obsidian dev vault CSS runtime check with obsidian vault=dev eval, confirming CSS.supports(...) is true, the mixed computed background applies, and dev:errors reports no errors.

Summary by CodeRabbit

  • Style
    • Improved preview sidebar styling with enhanced browser compatibility support.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4fd4675b-e0d5-4620-8e8f-7d3495accf9a

📥 Commits

Reviewing files that changed from the base of the PR and between 04b2e79 and 3ecc603.

📒 Files selected for processing (1)
  • docs/src/pages/index.module.css

📝 Walkthrough

Walkthrough

A CSS feature query is added to conditionally apply color-mix() background styling to the preview sidebar. The advanced color syntax now only activates in browsers that support it, with the original background value serving as the default fallback for unsupported browsers.

Changes

Preview Sidebar Color-Mix Fallback

Layer / File(s) Summary
Color-mix support fallback for preview sidebar
docs/src/pages/index.module.css
.previewSidebar background styling is wrapped in an @supports feature query to apply the color-mix() background only when the browser supports it, providing graceful degradation for older browsers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A sidebar dressed in vibrant hue,
Now checks what browsers know is true—
If color-mix is understood,
The fancy blend looks oh-so-good!
Else simple shades will have to do. 🎨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: it fixes a duplicate background warning in the docs by restructuring CSS rules with a @supports query.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docs-background-warning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ecc603
Status: ✅  Deploy successful!
Preview URL: https://5ad051ae.quickadd.pages.dev
Branch Preview URL: https://fix-docs-background-warning.quickadd.pages.dev

View logs

@chhoumann chhoumann marked this pull request as ready for review May 27, 2026 14:42
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@chhoumann chhoumann merged commit d277ff1 into master May 27, 2026
4 checks passed
@chhoumann chhoumann deleted the fix/docs-background-warning branch May 27, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant