[pull] master from fraunhoferhhi:master#164
Merged
Merged
Conversation
prevents shift of negative value later fixes #348
`offsetBlock` can receive block widths that are not multiples of eight. The previous Neon entry check rejected those blocks even though the picture buffers provide padded storage. Match the x86 SIMD behavior by allowing the eight-wide BO and EO loops to process the final vector while `x < width`, so the tail lands in the padded right margin instead of requiring an exact width match.
Add a non-multiple-of-8 width like 44 to the SAO `offsetBlock` unit test cases to exercise partial vector processing. Increase the test buffer right padding to model the right-margin headroom provided by the picture buffers allocated through `PicListManager::getNewPicBuffer`, and align the destination stride to an 8-Pel boundary so x86 aligned stores remain valid on every row while the final partial vector writes into padded storage.
…-width Fix offsetBlock_neon to handle non-multiple-of-8 widths
- reimplementation of x86-SIMD DeQuant (fix reading of uninitialized memory) - vvdec_unit_test allows specifying which test to run - cmake parameter -DVVDEC_WRITE_INPUT_BITSTREAM to allow writing the input bitstream to a file - some small bugfixes
Fix Undefined Behaviour
publish internal changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )