[pull] main from B-Lang-org:main#177
Merged
Merged
Conversation
byInst recorded the source package as used on every head-match, before sat decided whether to commit. Move recordPackageUse to sat, after satMany confirms sub-goals succeed, by threading Maybe Id through byInst to reducePred to sat. The bad_match/fail path never records a use. Add test 6c (BoolDescribable/UseOrphanSeparately) to test this recording path directly.
ctxreduce discarded tsUsedPackages (the third runTI result), so instance resolution during ctxredice was recorded in its TI monad and then lost. If the body code did not actually use the relevant dictionary, the relevant package looked unused and received a spurious unused-import warning. The fix is to include the packages recorded by ctxreduce in the set of all packages used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )