[pull] main from B-Lang-org:main#175
Merged
Merged
Conversation
Add macos-26-intel, ubuntu-26.04, ubuntu-24.04-arm, ubuntu-26.04-arm
This avoids assuming that GHCup is installed on the runner (which it is not, for GitHub's Ubuntu ARM runners). It replaces shell code that had been used for a similar situation for macOS runners.
splitITAp accumulated arguments with `as ++ [a]` while recursing down the type-application spine. That is O(n^2) in the spine length and reallocates the argument list at every level (~21% of allocation when compiling wide split-port types). Use a reverse-accumulator (descend the spine prepending args) so it is O(n) with no repeated appends. Result is identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isTFun (and PredTrie.isTFunTyCon) tested membership with `i `elem` numOpNames ++ strOpNames`, which rebuilds the (10-element) list and does a linear scan of idEq comparisons on every call. isTFun is called once per type constructor during type expansion/normalization, so on wide types it dominates: profiling a 521-port always_ready struct method (a port-shape boundary module) showed id_fs/idEq/isTFun as the top cost centres, ~30% of allocation. Precompute the operator-name set once and use Set membership instead. Semantics-preserving. On the struct-form module above this cut the BscV elaboration ~12% (131.3s -> 115.6s, isolated). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )