[pull] main from B-Lang-org:main#174
Merged
Merged
Conversation
…ch (PR 980)
When satMany' only partially reduces a predicate (the "still-needed" /
Right branch), it commits the learned substitution s' to the accumulator
(s' @@ s) but did not apply it to the not-yet-processed sibling
predicates ps. The fully-solved (Left) branch already does this
(apSub s' ps). Because of the asymmetry, a sibling predicate that is
determined (via a functional dependency) by a variable that s' had just
grounded was matched against an unbound variable and left unreduced, so
its own fundep never fired.
This surfaced as a spurious T0029 ("Signature mismatch (given too
general)"): a partially-solved proviso grounds the input of a sibling
fundep'd proviso, but because the grounding was not propagated the
sibling stayed unreduced and the instance's determined parameter was
left general in the declared head -- while the method body grounded it.
Fix: apply s' to ps in the Right branch too, matching the Left branch.
This only propagates an already-committed substitution, so it adds no
new reduction rounds and cannot affect termination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )