Fix small bugs#184
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a few numerical/output correctness issues in the reconstruction and diagnostic-output paths.
Changes:
- Fix WENO3 scaling on the CPU path by removing an unintended second normalization by
vscale. - Correct CP3 (center-3 polynomial) coefficients used by
Center3InterpImpl. - Restrict “path” diagnostic integration to the interior
i-range (il..iu) instead of summing over the full extent (including ghost zones).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/recon/interp_impl.h |
Removes a redundant vscale division in CPU WENO3 interpolation (fixes double-normalization). |
src/recon/cp3.cpp |
Updates CP3 coefficient tensor used for left/right interpolation. |
src/output/load_diag_output_data.cpp |
Slices to [il, iu] before summing along i when computing path-integrated tracer output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
16
| void Center3InterpImpl::reset() { | ||
| cm = register_buffer( | ||
| "cm", torch::tensor({-1. / 3., 5. / 6., -1. / 6.}, torch::kFloat64)); | ||
| "cm", torch::tensor({1. / 3., 5. / 6., -1. / 6.}, torch::kFloat64)); | ||
| cp = register_buffer("cp", cm.flip({0})); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.