Add PICASO CK table#130
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new PICASO correlated‑k (NetCDF) opacity table format and wires it into the RadiationBand opacity factory, alongside a small adjustment to Toon solver handling (default args + Planck/temperature gating).
Changes:
- Add
PicasoCKopacity implementation (NetCDF reader + interpolation-based forward). - Register
"picaso-ck"as a supported opacity type inRadiationBand(docs + factory switch) and in the Python type stub. - Update Toon solver integration to (a) expose forward default args metadata and (b) only pass temperatures to the solver when Planck emission is enabled; ensure Toon has at least 3 optical-property slots.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rtsolver/toon_mckay89.hpp | Exposes forward default-argument metadata for Toon module. |
| src/radiation/radiation_band.hpp | Documents the new "picaso-ck" opacity type. |
| src/radiation/radiation_band.cpp | Adds PicasoCK factory path; adjusts Toon property sizing and temperature/Planck handling. |
| src/opacity/picaso_ck.hpp | Declares the new PICASO correlated‑k opacity module. |
| src/opacity/picaso_ck.cpp | Implements NetCDF loading and interpolated opacity evaluation. |
| python/opacity.pyi | Updates the documented valid OpacityOptions.type values to include "picaso-ck". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.