Fix species dump#129
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the xsection “species dump” dataset construction so that the wavenumber dimension/coordinate is renamed cleanly (without leaving the legacy wavenumber_cm1 coordinate behind), and adds a regression test to prevent regressions.
Changes:
- Update
_xsection_dataset()to usexarray.Dataset.rename(...)(instead ofrename_vars(...)+swap_dims(...)) so thewavenumber_cm1dimension/coord is fully renamed towavenumber. - Add a unit test asserting the resulting dataset has only the
wavenumberdimension and no leftoverwavenumber_cm1coord/dim.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
python/spectra/dump_cli.py |
Ensures xsection datasets rename the wavenumber_cm1 dimension/coord to wavenumber without leaving legacy coordinates. |
tests/spectra/test_cli.py |
Adds regression coverage to confirm the legacy wavenumber_cm1 dim/coord is not present after dataset construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chengcli
force-pushed
the
cli/fix_specie_dump
branch
from
915ec14 to
cae7e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.