Skip to content

Add bryan case vapor function#99

Merged
chengcli merged 2 commits into
mainfrom
cli/add_bryan_vapor
Jul 2, 2026
Merged

Add bryan case vapor function#99
chengcli merged 2 commits into
mainfrom
cli/add_bryan_vapor

Conversation

@chengcli

@chengcli chengcli commented Jul 2, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 2, 2026 20:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new saturation vapor pressure formulation for water (“Bryan” liquid-branch form), wires it into the function-dispatch registry (CPU + CUDA), and introduces unit tests to validate both the direct function and the LogSVPFunc dispatch path.

Changes:

  • Added h2o_bryan(T) and h2o_bryan_ddT(T) vapor functions.
  • Registered the new functions in the CPU and CUDA function tables and exposed their names for string-based dispatch.
  • Added a new GTest suite covering numeric correctness, below-triple-point behavior, and LogSVPFunc routing.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_vapor_functions.cpp Adds unit tests validating h2o_bryan and its derivative, including dispatch through LogSVPFunc.
tests/CMakeLists.txt Registers the new vapor-functions test target with the test suite.
src/vapors/vapor_functions.h Implements h2o_bryan and h2o_bryan_ddT using the existing logsvp_ideal* helpers.
src/func_table.cu Adds CUDA-side function pointers for h2o_bryan and h2o_bryan_ddT in the device dispatch table.
src/func_table.cpp Adds CPU-side function pointers and name registry entries for the new Bryan functions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chengcli chengcli merged commit 3bc73d3 into main Jul 2, 2026
3 checks passed
@chengcli chengcli deleted the cli/add_bryan_vapor branch July 2, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants