Add bryan case vapor function#99
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new saturation vapor pressure formulation for water (“Bryan” liquid-branch form), wires it into the function-dispatch registry (CPU + CUDA), and introduces unit tests to validate both the direct function and the LogSVPFunc dispatch path.
Changes:
- Added
h2o_bryan(T)andh2o_bryan_ddT(T)vapor functions. - Registered the new functions in the CPU and CUDA function tables and exposed their names for string-based dispatch.
- Added a new GTest suite covering numeric correctness, below-triple-point behavior, and
LogSVPFuncrouting.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_vapor_functions.cpp | Adds unit tests validating h2o_bryan and its derivative, including dispatch through LogSVPFunc. |
| tests/CMakeLists.txt | Registers the new vapor-functions test target with the test suite. |
| src/vapors/vapor_functions.h | Implements h2o_bryan and h2o_bryan_ddT using the existing logsvp_ideal* helpers. |
| src/func_table.cu | Adds CUDA-side function pointers for h2o_bryan and h2o_bryan_ddT in the device dispatch table. |
| src/func_table.cpp | Adds CPU-side function pointers and name registry entries for the new Bryan functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.