Issue #18064: added ArrayBracketNoWhitespace check by M-SaaD-H · Pull Request #18240 · checkstyle/checkstyle

M-SaaD-H · 2025-12-03T16:37:26Z

New module config: https://gist.githubusercontent.com/M-SaaD-H/4550b2874ee138f74ef18ca95b45c596/raw/7091fa5650a9bb166694a74a36ce601e7beeef7e/arraybracketnowhitespace.xml

Contribution repo: checkstyle/contribution#1007

romani · 2025-12-05T05:14:12Z

Please read and watch videos at Starting_Development.
Please make CI green.

M-SaaD-H · 2025-12-05T05:30:02Z

Hi @romani ,
I have tested the check locally before raising the PR, but overlooked the XpathRegression tests. I am sorry for this, but I am facing some issues in passing these tests. I have asked this in the discord channel but didn't got the solution from there too. It will be really helpful if you could help me in understanding and solving this issue.
Tagged you in the related thread on discord.

romani · 2025-12-05T06:02:47Z

Just debug test and trace all lines to understand why there is no violation. All is debug-able.

SURYANSHUAGRAWAL2006 · 2025-12-05T06:30:06Z

@saad please make sure commit should be only one so, please squash all commits into single one.

mohitsatr · 2025-12-07T07:28:19Z

@M-SaaD-H please push the changes so we can see what's wrong with XpathRegression tests. It's little hard to understand from images.

M-SaaD-H · 2025-12-07T07:32:33Z

@mohitsatr I have pushed the code.
Please look into it.

M-SaaD-H · 2025-12-11T15:16:44Z

Hi @mohitsatr can you please look into the CIs, I can't really get why they are failing.

SURYANSHUAGRAWAL2006 · 2025-12-11T17:27:43Z

Hello Saad my advice is that you have to be run the command mvn clean verify again and run this command again and again until BUILD SUCCESS will not encountered because same error also came in my checks so I simply did to ran command mvn clean verify and when BUILD SUCCESS showing then I push my code and all checks passed.
so, please go through this.

M-SaaD-H · 2025-12-11T17:52:09Z

Hi @SURYANSHUAGRAWAL2006 ,
Thanks for your advice. I have already verified that build is success locally. I am getting BUILD SUCCESS message when I run mvn clean verify. This error is only showing when I push my changes. Moreover, I can't find the actual reason for the failure of these CI pipelines.

vivek-0509 · 2025-12-11T18:19:27Z

For the run-inspections failure open the ci failes they have given this link
https://app.circleci.com/pipelines/github/checkstyle/checkstyle/38573/workflows/43e71112-f6c4-4ca9-8d52-4a0ed937de87/jobs/1167874/artifacts

you will se the inspections result open those links and fix those issues

Similarly for other CI failures check the logs

SURYANSHUAGRAWAL2006 · 2025-12-11T18:28:57Z

Hello Saad I saw your build failure this is occurring not because of your code or check style it is because of maven problem so, Kindly rerun all CI best way close the pr then reopen the pr then all CI will run again and then you check all CI is passing or not but I am sure this is not your code problem rather than it is problem of maven internal.

M-SaaD-H · 2025-12-12T11:45:15Z

Hi @romani
Can you please look into it?

mohitsatr · 2025-12-16T14:23:59Z

@M-SaaD-H Green CI is a good sign. Take to run regression.

Please go through the section Executing generation using github action and try to generate the report.

Example PR: #17329

M-SaaD-H · 2025-12-16T19:52:06Z

GitHub, generate report

github-actions · 2025-12-16T19:53:24Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/20280771915

github-actions · 2025-12-16T19:54:30Z

Report generation failed on phase "make_report",
step "Generate report".
Link: https://github.com/checkstyle/checkstyle/actions/runs/20280805281

mohitsatr · 2025-12-17T05:16:10Z

@M-SaaD-H Config in the Pr's description is not valid. It has to be like: https://gist.githubusercontent.com/mohitsatr/0e04070f847926ea44bf7eda88706807/raw/f9470db307d730a651e9c93cad776d6b592839e8/textblockgooglestyleformatting.xml. Replace Textb...Check with your check

github-actions · 2026-06-05T11:43:23Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/f4ef25f_2026114113/reports/diff/index.html

Atharv3221

Improve

Atharv3221 · 2026-06-06T12:46:52Z

    </details>
  </checkerFrameworkError>

+


remove extra blank line

Atharv3221

Minor

Atharv3221 · 2026-06-06T12:47:43Z

GitHub, generate website

github-actions · 2026-06-06T12:51:19Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c05d721_20260606125013/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c05d721_20260606125013/checks.html#Standard_Checks

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c05d721_20260606125013/checks/whitespace/arraybracketnowhitespace.html#

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/c05d721_20260606125013/checks/whitespace/index.html#Whitespace_Checks

Atharv3221 · 2026-06-06T12:57:04Z

ping @romani

Atharv3221 · 2026-06-07T06:17:44Z

ping @mohitsatr

Zopsss

items:

Zopsss · 2026-06-10T10:56:10Z

+
+public class InputArrayBracketNoWhitespaceBranchCoverage {
+
+    // Edge cases to cover missing branches in findClosestTokenAfter


what is findClosestTokenAfter ? and please remove this line.

also rename the file name, no need to mention BranchCoverage

Zopsss · 2026-06-10T10:59:31Z

+
+        // Nested array access with complex expressions
+        int[][] matrix = new int[5][5];
+        int result1 = matrix[arr[0]][arr[1]];


int result2 = matrix[ arr[0]][arr[1 ]];

add this case

Zopsss · 2026-06-10T11:00:29Z

+        int[] arr2 = new int [10]; // violation ''\[' is preceded with whitespace.'
+        int[] arr3 = new int[ 10]; // violation ''\[' is followed by whitespace.'
+        int[] arr4 = new int[10 ]; // violation ''\]' is preceded with whitespace.'
+        int[] arr5 = new int[ 10 ];


add one more case here:

int []arr5 = new int[10];

Zopsss · 2026-06-10T11:04:51Z

add 2 examples, one should contain correct code only and other should contain violations.

Zopsss · 2026-06-10T11:11:26Z

GitHub, generate report

M-SaaD-H · 2026-06-10T14:34:06Z

GitHub, generate report

github-actions · 2026-06-10T15:11:56Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/6963b5f_2026150836/reports/diff/index.html

M-SaaD-H · 2026-06-10T15:18:51Z

Hey @Zopsss ,
I've addressed all the review comments and generated the report. Please take a look when you get the chance.

Zopsss · 2026-06-12T16:28:29Z

False-positive:

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/6963b5f_2026150836/reports/diff/apache-ant/index.html#A7

The rsc[i] should not be followed by a whitespace as there is closing bracket (});) after it so it is fine.

Similar other case: https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/6963b5f_2026150836/reports/diff/apache-ant/index.html#A8

Zopsss · 2026-06-12T16:41:31Z

@M-SaaD-H fyi, do not wait for maintainers to review the report. You should do it yourself and report any false-positive/negative you find and fix them. It accelerates the review process

M-SaaD-H · 2026-06-13T06:59:12Z

I initially assumed these were valid violations since formatter output often uses spaces in cases like { bytes[0] }. Since the intended behavior is to allow {bytes[0]}, I've updated the logic and pushed the fix.

M-SaaD-H · 2026-06-13T07:18:19Z

GitHub, generate report

github-actions · 2026-06-13T07:48:13Z

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/0a7236b_2026074608/reports/diff/index.html

M-SaaD-H · 2026-06-13T14:58:25Z

Hey @Zopsss ,
I've fixed the previous false positive and generated the report. Please take a look when you get the chance.

M-SaaD-H force-pushed the 18064 branch from 4c86f61 to b0ad54a Compare December 7, 2025 07:31

mohitsatr reviewed Dec 8, 2025

View reviewed changes

Comment thread ...ckstyle/checks/whitespace/arraybracketnowhitespace/InputArrayBracketNoWhitespaceDefault.java Outdated

Comment thread ...ckstyle/checks/whitespace/arraybracketnowhitespace/InputArrayBracketNoWhitespaceDefault.java Outdated

M-SaaD-H force-pushed the 18064 branch from 10b600a to 65b6356 Compare December 11, 2025 11:31

M-SaaD-H force-pushed the 18064 branch 2 times, most recently from ce465be to b2c32cd Compare December 16, 2025 06:27

M-SaaD-H requested review from mohitsatr December 16, 2025 12:35

M-SaaD-H force-pushed the 18064 branch 2 times, most recently from bf67dc9 to 8bb25c4 Compare December 16, 2025 13:57

M-SaaD-H force-pushed the 18064 branch 4 times, most recently from 47b8d0f to 4d1133d Compare December 16, 2025 17:23

Atharv3221 reviewed Jun 5, 2026

View reviewed changes

Comment thread config/checker-framework-suppressions/checker-nullness-optional-interning-suppressions.xml Outdated

Atharv3221 reviewed Jun 5, 2026

View reviewed changes

M-SaaD-H force-pushed the 18064 branch 2 times, most recently from b3e5050 to c05d721 Compare June 5, 2026 17:28

Atharv3221 reviewed Jun 6, 2026

View reviewed changes

Atharv3221 approved these changes Jun 6, 2026

View reviewed changes

M-SaaD-H force-pushed the 18064 branch from c05d721 to 58e99ed Compare June 6, 2026 13:51

Zopsss suggested changes Jun 10, 2026

View reviewed changes

M-SaaD-H force-pushed the 18064 branch from 58e99ed to 6963b5f Compare June 10, 2026 14:33

M-SaaD-H force-pushed the 18064 branch from 6963b5f to e6e1da3 Compare June 10, 2026 14:57

M-SaaD-H requested a review from Zopsss June 11, 2026 08:17

M-SaaD-H force-pushed the 18064 branch from e6e1da3 to 2612f99 Compare June 13, 2026 06:56

Issue checkstyle#18064: add ArrayBracketNoWhitespace check

0a7236b

M-SaaD-H force-pushed the 18064 branch from 2612f99 to 0a7236b Compare June 13, 2026 07:01


		public class InputArrayBracketNoWhitespaceBranchCoverage {

		// Edge cases to cover missing branches in findClosestTokenAfter

Uh oh!

Conversation

M-SaaD-H commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romani commented Dec 5, 2025

Uh oh!

M-SaaD-H commented Dec 5, 2025

Uh oh!

romani commented Dec 5, 2025

Uh oh!

SURYANSHUAGRAWAL2006 commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mohitsatr commented Dec 7, 2025

Uh oh!

M-SaaD-H commented Dec 7, 2025

Uh oh!

Uh oh!

Uh oh!

M-SaaD-H commented Dec 11, 2025

Uh oh!

SURYANSHUAGRAWAL2006 commented Dec 11, 2025

Uh oh!

M-SaaD-H commented Dec 11, 2025

Uh oh!

vivek-0509 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SURYANSHUAGRAWAL2006 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

M-SaaD-H commented Dec 12, 2025

Uh oh!

mohitsatr commented Dec 16, 2025

Uh oh!

M-SaaD-H commented Dec 16, 2025

Uh oh!

github-actions Bot commented Dec 16, 2025

Uh oh!

github-actions Bot commented Dec 16, 2025

Uh oh!

mohitsatr commented Dec 17, 2025

Uh oh!

github-actions Bot commented Jun 5, 2026

Uh oh!

Uh oh!

Atharv3221 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Atharv3221 left a comment

Choose a reason for hiding this comment

Uh oh!

Atharv3221 commented Jun 6, 2026

Uh oh!

github-actions Bot commented Jun 6, 2026

Uh oh!

Atharv3221 commented Jun 6, 2026

Uh oh!

Atharv3221 commented Jun 7, 2026

Uh oh!

Zopsss left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

M-SaaD-H commented Dec 3, 2025 •

edited

Loading

SURYANSHUAGRAWAL2006 commented Dec 5, 2025 •

edited

Loading

vivek-0509 commented Dec 11, 2025 •

edited

Loading

SURYANSHUAGRAWAL2006 commented Dec 11, 2025 •

edited

Loading

Zopsss commented Jun 12, 2026 •

edited

Loading