claude provider: properly handle "withThinking"

[Pascal-Delange]

See thread in checkmarble/marble-backend#1277.

The implementation was not properly handling thinking without a budget.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a52b0062-beb1-4c0e-b669-4f095673b406

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch pascal/fix-claude-thinking

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[OrriMandarin]

LGTM

A minor remark, but it can be treated independently.

[OrriMandarin]

We can avoid defining a "default" budget by utilizing the ThinkingConfigAdaptiveParam option to control the thinking feature. (instead of ThinkingConfigParamOfEnabled).
The AdaptiveParam feature allows Claude to determine the budget allocation based on the complexity of the request. I believe this feature is a perfect match.

This can be implemented in another PR.