test(coverage): push llm-reply/rag-reply/notifications/testkit to 100% lines#785
Merged
Conversation
…% lines - llm-reply: 3 tests for resolveExchangeCollected/.CustomerNoticeEnabled/.catch and conversationsRepoFor.findById onWarn path - rag-reply: test for suggestions.log fire-and-forget .catch path - notifications: 3 tests — sendReferencedMedia (no downloader, all 4 kinds), downloadPreviewMedia 500→catch fires→fallthrough, defaultContentType fallback - testkit: 5 tests for FakeMessagesRepo.insert/setTranslation/getTranslation edge cases Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Bundle ReportBundle size has no change ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.catchобработчиковresolveExchangeCollected,resolveExchangeCustomerNoticeEnabledиonWarnдля conversation summary.catchвsuggestions.logsendReferencedMedia(no downloader, все 4 типа медиа),downloadPreviewMedia500→catch→fallthrough,defaultContentTypefallbackFakeMessagesRepo.insert/setTranslation/getTranslationTest plan
bun test packages/conversation-engine— 648/648 passbun run typecheck— чистый🤖 Generated with Claude Code