feat: On Nauta, continue deleting messages immediately in single-device mode#8290
Closed
Hocuri wants to merge 2 commits into
Closed
feat: On Nauta, continue deleting messages immediately in single-device mode#8290Hocuri wants to merge 2 commits into
Hocuri wants to merge 2 commits into
Conversation
Collaborator
Collaborator
|
This will delete unencrypted messages as well, maybe fine, not sure if we want to do this. |
Collaborator
Author
|
OK, seems unlikely at least that we want this in Core. We can ask @adbenitez about ArcaneChat, but I would assume that #8283 is enough even there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a way to make sure that on Nauta, the old behavior of deleting messages immediately in single-device mode (because of the small storage) is restored.
Now, we can decide whether we merge this into Core, or only into ArcaneChat. CC @adbenitez.
TODO:
Optional TODOs: (not sure how big @adbenitez's code quality requirements are in ArcaneChat):