feat: update image-registry default to ghcr.io/canonical/cdk - #98
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
louiseschmidtgen
added a commit
to charmed-kubernetes/charm-containerd
that referenced
this pull request
Aug 10, 2026
pbr<6.1.1 (pulled in transitively) fails to build on Python 3.12/3.10 with 'ModuleNotFoundError: No module named pkg_resources' since setuptools no longer vendors pkg_resources by default. Pinning to pbr==7.0.3 resolves this, matching the fix applied in charmed-kubernetes/charm-flannel#98.
canonicalmateo
approved these changes
Aug 10, 2026
louiseschmidtgen
changed the title
canonicalmateo
pushed a commit
to charmed-kubernetes/charm-containerd
that referenced
this pull request
Aug 11, 2026
* Update image-registry default to ghcr.io/canonical/cdk * Fix unit test: update registry assertion to ghcr.io/canonical/cdk * Apply black formatting to tests/unit/conftest.py * Apply black formatting to tests/integration/test_containerd_integration.py * fix: pin pbr==7.0.3 in wheelhouse to fix validate-wheelhouse CI pbr<6.1.1 (pulled in transitively) fails to build on Python 3.12/3.10 with 'ModuleNotFoundError: No module named pkg_resources' since setuptools no longer vendors pkg_resources by default. Pinning to pbr==7.0.3 resolves this, matching the fix applied in charmed-kubernetes/charm-flannel#98.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocks.canonical.com is being retired. This PR updates the image registry references from the legacy registry to the new GitHub Container Registry.
Changes:
This updates the test integration image reference to use the new registry.