Skip to content

Update default addon (storage) - #56

Open
beliaev-maksim wants to merge 2 commits into
charmed-kubernetes:mainfrom
beliaev-maksim:patch-3
Open

Update default addon (storage)#56
beliaev-maksim wants to merge 2 commits into
charmed-kubernetes:mainfrom
beliaev-maksim:patch-3

Conversation

@beliaev-maksim

Copy link
Copy Markdown

No description provided.

@beliaev-maksim beliaev-maksim changed the title Update README.md Update default addon (storage) Apr 17, 2023
@addyess

addyess commented Apr 17, 2023

Copy link
Copy Markdown

@beliaev-maksim what's the reason for the change here?

@neoaggelos should this differ based on the version of microk8s installed?

@beliaev-maksim

Copy link
Copy Markdown
Author

@addyess 1.24 is the latest version supported. And in this version we already should use different syntax, in 1.27-28 it should be removed entirely

@addyess

addyess commented Apr 17, 2023

Copy link
Copy Markdown

this change would likely cause trouble with users who have old microk8s versions pinned:

If someone wishes to change the addons in a specific configuration, one can just use the microk8s-addons option available in the action:

  integration-test:
    runs-on: ubuntu-22.04
    steps:
    - name: Check out code
      uses: actions/checkout@v2
    - name: Setup operator environment
      uses: charmed-kubernetes/actions-operator@main
      with:
        provider: microk8s
        channel: 1.27/stable
        microk8s-addons: "hostpath-storage dns rbac"

@beliaev-maksim

Copy link
Copy Markdown
Author

@addyess should not people who use old unsupported versions pin a version of the action, eg 1.1.0 ?

@addyess

addyess commented Apr 17, 2023

Copy link
Copy Markdown

@addyess should not people who use old unsupported versions pin a version of the action, eg 1.1.0 ?

its my understanding that the the storage alias isn't going away anytime soon and is still safe to use in 1.27 and 1.28

@beliaev-maksim

Copy link
Copy Markdown
Author

@addyess why does microk8s report a warning saying it is deprecated ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants