added 15 min timeout on mk8s status - #54
Open
beliaev-maksim wants to merge 4 commits into
Open
Conversation
addyess
reviewed
Apr 17, 2023
addyess
suggested changes
Apr 17, 2023
addyess
left a comment
addyess
left a comment
There was a problem hiding this comment.
Shouldn't the operator wait for a stable microk8s?
Co-authored-by: Adam Dyess <adam.dyess@canonical.com>
addyess
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
This looks better i'd think we could go ahead and merge although this isn't finished canonical/microk8s#3927
Nevermind -- with CI failing there's still something wrong with microk8s not returning exit codes correctly.
addyess
reviewed
Apr 19, 2023
addyess
left a comment
addyess
left a comment
There was a problem hiding this comment.
Suggesting alternate error reporting text
Co-authored-by: Adam Dyess <adam.dyess@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently we will wait indefinitely in case of error. 15min sounds like a reasonable timeout