feat: anon and keyless access#914
Open
mdgreenwald wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Greenwald <mdgreenwald@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SOFT_SERVE_ANON_ACCESS/SOFT_SERVE_ALLOW_KEYLESSconfig and env overrides for theanon-accessandallow-keylesssettings.Today those settings are DB-backed and only mutable via an authenticated
settingscommand, so scripting a fully open server from a cold start requires booting with an admin key, waiting for SSH, then runningsettingsas that admin. These overrides let local/dev tooling (e.g. a throwaway Git remote for CI or local scripts) set both at boot with no admin key and nosettingscall.initial_admin_keysalready behaves (not a one-time seed).settings anon-access/settings allow-keylesswhile a config override is active now warns that the DB write has no effect until the override is removed.Issue: #758
Testing
Unit tests for config parsing/validation and override precedence in the backend.
New
anon-access-env.txtarintegration test covering zero-touch bootstrap over SSH/git.I have read
CONTRIBUTING.md.I have created a discussion that was approved by a maintainer (for new features).