fix(hooks): propagate custom hook failures#910
Open
Solaris-star wants to merge 1 commit into
Open
Conversation
Author
|
Verified against upstream main at 16c8e08. There are no competing open PRs for #909. Focused package tests and vet pass; full go test reaches the existing testscript suite but is blocked locally by missing Git LFS and unrelated baseline failures. The patch is intentionally limited to propagating the custom hook exit error plus focused regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A custom executable global hook's exit status was logged and then discarded by
soft hook, causing Git to accept pushes even when apre-receivehook rejected them.This change returns the custom hook error from
hooksRunE, so the generated Git hook dispatcher can propagate the failure to Git. It also extracts the executable-hook lookup intorunCustomHookand adds focused tests covering failure propagation and ignored missing/non-executable hooks.Fixes #909
Validation
go test ./cmd/soft/hook ./pkg/hooksgo vet ./cmd/soft/hook ./pkg/hooksgo test ./...(the package tests pass; the existing testscript suite requires Git LFS in the local environment and fails before exercising this change)