fix(examples): use go.work instead of replace directive#1682
Open
phlx0 wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix(examples): use go.work instead of replace directive#1682phlx0 wants to merge 1 commit intocharmbracelet:mainfrom
phlx0 wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
The replace directive in examples/go.mod prevented users from running examples remotely via `go run charm.land/bubbletea/examples/...@latest`. Replace it with a go.work.example template that contributors can copy to go.work locally. go.work and go.work.sum are now gitignored. Fixes charmbracelet#1681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
replacedirective inexamples/go.modbreaksgo runwhen fetching from the module proxy:Dropped the
replaceand addedgo.work.exampleinstead. Copy it togo.workfor local dev — same effect, doesn't break remote runs.Also added
go.workandgo.work.sumto.gitignore.Closes #1681