Skip to content

Drop AllocCheck get_pgcstack_static monkeypatch#1210

Merged
sunxd3 merged 1 commit into
mainfrom
sunxd/drop-alloccheck-pgcstack-patch
Jun 15, 2026
Merged

Drop AllocCheck get_pgcstack_static monkeypatch#1210
sunxd3 merged 1 commit into
mainfrom
sunxd/drop-alloccheck-pgcstack-patch

Conversation

@sunxd3

@sunxd3 sunxd3 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

AllocCheck.jl PR #100 added "get_pgcstack_static" to the non-allocating allowlist, shipped in AllocCheck 0.2.5. The init patch in MooncakeAllocCheckExt that redefined fn_may_allocate to work around the arm64 false positive is now redundant, so remove it and tighten the AllocCheck compat bound to 0.2.5.

CI Summary — GitHub Actions

Documentation Preview

Mooncake.jl documentation for PR #1210 is available at:
https://chalk-lab.github.io/Mooncake.jl/previews/PR1210/

Performance

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌───────────────────────┬──────────┬──────────┬─────────────┬─────────┬─────────────┬────────┐
│                 Label │   Primal │ Mooncake │ MooncakeFwd │  Zygote │ ReverseDiff │ Enzyme │
│                String │   String │   String │      String │  String │      String │ String │
├───────────────────────┼──────────┼──────────┼─────────────┼─────────┼─────────────┼────────┤
│              sum_1000 │ 200.0 ns │     1.45 │        1.55 │    0.65 │        3.26 │   6.36 │
│             _sum_1000 │   1.1 μs │     5.98 │        1.02 │  3690.0 │        40.2 │   1.06 │
│          sum_sin_1000 │  7.42 μs │     2.48 │        1.12 │    1.65 │        10.8 │   1.71 │
│         _sum_sin_1000 │  4.61 μs │     3.82 │        2.67 │   394.0 │        17.6 │   3.09 │
│              kron_sum │ 198.0 μs │     13.1 │        3.24 │     7.3 │       527.0 │   21.6 │
│         kron_view_sum │ 264.0 μs │     12.8 │        5.32 │    28.6 │       494.0 │   13.8 │
│ naive_map_sin_cos_exp │  2.24 μs │     2.78 │        1.54 │ missing │        8.29 │   2.12 │
│       map_sin_cos_exp │  2.15 μs │     3.39 │        1.65 │    1.53 │        7.48 │   2.73 │
│ broadcast_sin_cos_exp │  2.23 μs │     3.02 │        1.58 │     4.4 │        1.44 │   2.13 │
│            simple_mlp │ 343.0 μs │     5.07 │        2.95 │    2.15 │        10.7 │   3.22 │
│                gp_lml │ 168.0 μs │     11.5 │        2.55 │    5.08 │     missing │   5.42 │
│    large_single_block │ 471.0 ns │     5.34 │        1.93 │  4020.0 │        32.2 │   2.08 │
└───────────────────────┴──────────┴──────────┴─────────────┴─────────┴─────────────┴────────┘

AllocCheck.jl PR #100 added "get_pgcstack_static" to the non-allocating
allowlist, shipped in AllocCheck 0.2.5. The __init__ patch in
MooncakeAllocCheckExt that redefined fn_may_allocate to work around the
arm64 false positive is now redundant, so remove it and tighten the
AllocCheck compat bound to 0.2.5.
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sunxd3 sunxd3 merged commit fe6f232 into main Jun 15, 2026
92 checks passed
@sunxd3 sunxd3 deleted the sunxd/drop-alloccheck-pgcstack-patch branch June 15, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant