Abundance speed#34
Open
cgiovanetti wants to merge 2 commits into
Open
Conversation
Precompute log(T9_vec), log(mu_median_vec), log(expsigma_vec) once at construction instead of recomputing them on every frwrd_rate_param call. Algebraically identical (abundances bit-for-bit unchanged); ~5% faster on 60-row rate tables, ~10% on 500-row dense tables (recovers the dense-table interpolation penalty). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull construction of
rate_vecout of RHS of ODE solve for abundances to avoid reconstruction of this array at every step in the solve. Now only computes once per call/once pernuclear_rates_q. ~15% speedup of abundance module.