Support more commands, reorder, raise error with screenshot and camshot#25
Merged
Conversation
cgarwood
requested changes
Aug 26, 2024
cgarwood
left a comment
cgarwood
left a comment
Owner
There was a problem hiding this comment.
Thanks! One comment on the start/stop daydream commands, but otherwise looks good.
|
Hi @cgarwood is it possible to release a new version of the library? I would like to use the new triggerMotion command from this PR,, but there is no new release after this merge. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this package.
Added some missing commands.
Commands used to be in the order of contributions. I reordered them similar to official docs, and grouped them by similarity. Much easier to read the code this way.
getCamshotandgetScreenshotnow raises an error just like any other commands.Tested this with my tablet running "Fully Single App Kiosk" .
Supersedes #18