Skip to content

refactor: extract AliasAttribute type and fix subscriber memory leak#84

Open
cgarciagarcia wants to merge 2 commits into
mainfrom
refactor/subscriber-cleanup-alias-type
Open

refactor: extract AliasAttribute type and fix subscriber memory leak#84
cgarciagarcia wants to merge 2 commits into
mainfrom
refactor/subscriber-cleanup-alias-type

Conversation

@cgarciagarcia

Copy link
Copy Markdown
Owner

Summary

  • refactor: Extrae el tipo repetido `Al extends object ? (keyof Al & string) | string : string` a `AliasAttribute` en `types/index.ts` — elimina la duplicación en `Filter`, `Sort`, `QueryBuilder` y `Builder`
  • fix: `useQueryBuilder` ahora llama `removeSubscriber` al desmontar — evita memory leak cuando el componente se monta/desmonta múltiples veces
  • fix: Corrige el import path en `useQueryBuilder.ts` de `src/types` a `@/types`

Test plan

  • 171/171 tests pasando
  • Lint sin warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant