fix(ircclient): use format verbs instead of string concatenation in fmt.Fprintf#132
Merged
Merged
Conversation
…mt.Fprintf calls Resolves go vet printf check failures surfaced by gin v1.12.0's updated minimum Go version requirement. Non-constant format strings are unsafe and flagged as build errors by the printf analyzer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ircclientsurfaced by the gin v1.12.0 upgrade (fix(deps): update module github.com/gin-gonic/gin to v1.12.0 #117)fmt.Fprintfcalls that used string concatenation for the format argument (e.g."NICK "+nick+"\r\n") are replaced with proper format verbs (e.g."NICK %s\r\n", nick)handlers.goThe
go vetprintf analyzer flags non-constant format strings as errors; gin v1.12.0's bumped minimum Go version in itsgo.modcaused this to be enforced duringgo test.Test plan
go vet ./ircclient/...passes cleanly🤖 Generated with Claude Code