Skip to content

fix wrong reload acl button position - #144

Closed
kduret wants to merge 2 commits into
developfrom
MON-migration-MON-15591-fix_reload_acl_button
Closed

fix wrong reload acl button position#144
kduret wants to merge 2 commits into
developfrom
MON-migration-MON-15591-fix_reload_acl_button

Conversation

@kduret

@kduret kduret commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

Description

when you go to administraton → acl → reload acl menu, you’ll have the list of your connected users in a table. The last column should display the reload icon.

instead, the icon is displayed at the top of the page
image

jira: MON-15591

Fixes #11625 (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

without this PR:

  • connect a non admin user to your centreon
  • use private mode or another web brower to log in with an admin user
  • with your admin user, go to the administration -> acl -> reload acl menu
  • you'll notice that the reload acl icon is displayed at the top of the page instead of being in the right column of the table

with this patch, the icon is now displayed where it should be

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@kduret

kduret commented Nov 8, 2022

Copy link
Copy Markdown
Contributor Author

migrated from centreon-archive/centreon-archived#12013

sc979 pushed a commit to sc979/centreon that referenced this pull request Dec 12, 2022
sc979 added a commit to sc979/centreon that referenced this pull request Dec 12, 2022
* chore(php version): fix warning (centreon#112)

* new workflow

* hotfixing jenkinsfile

* fix(comments): display correctly last comments (centreon#115)

* enh(chore): automate dependabot ticket creation (centreon#116)

* fix(chore): old dependabot's PR ticket creation (centreon#117)

* enh(feature-switch): fully manage feature switch (centreon#114)

* enh(feature-switch): fully manage feature switch

* fix(index): wrong variable used

* fix qabranch variable

* enh(chore): issueType, feature_team and issue description

* chore(version): prepare 22.04 serie (centreon#120)

* chore(version): prepare 22.04 serie

* Update Jenkinsfile

* fix(secu): add SQ pipeline timeout (centreon#128)

* fix(chore): use github action env usage (centreon#129)

* fix(build): disable centos8 packaging (centreon#130)

* fix(chore): dependabot github automation (centreon#131)

* alma8 enabled (centreon#132)

* feat(ui): Apply dark mode for widget host monitoring  (centreon#136)

* fix(css): fix ccs import (centreon#138)

* chore(version): prepare 22.04.next (centreon#140)

* Merge release-debian-22.04.0 into 22.04.x (centreon#145)

* fix debian

* Update Jenkinsfile

* Update Jenkinsfile

* add version check version of dependency and remove unused file

Co-authored-by: Zakaria GUENNOUNE <zguennoune@centreon.com>
Co-authored-by: Luiz Costa <me@luizgustavo.pro.br>

* enh(secu): update GPG key (centreon#126)

* fix(secu): change fingerprint key (centreon#127)

* Add configuration to build DEB package (centreon#137)

* add deb package

* fix project name

* fix package name

* fix package name

* add delivery

* fix : Issue with cross databases query when the name contains some characters (centreon#144)

Co-authored-by: jeremyjaouen <61694165+jeremyjaouen@users.noreply.github.com>
Co-authored-by: Zakaria Guennoune <zguennoune@centreon.com>
Co-authored-by: Adrien Morais <31647811+adr-mo@users.noreply.github.com>
Co-authored-by: sc979 <34628915+sc979@users.noreply.github.com>
Co-authored-by: schapron <schapron@centreon.com>
Co-authored-by: Charles Gautier <33026375+chgautier@users.noreply.github.com>
Co-authored-by: ataghzout <97593248+ataghzout@users.noreply.github.com>
Co-authored-by: Laurent Pinsivy <lpinsivy@centreon.com>
Co-authored-by: Luiz Costa <me@luizgustavo.pro.br>
Co-authored-by: Zakaria Guennoune <83596451+zguennoune02@users.noreply.github.com>
Co-authored-by: hyahiaoui-ext <97593234+hyahiaoui-ext@users.noreply.github.com>
@bdauria

bdauria commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

@kduret can we fix the build and move forward with this?

@kduret

kduret commented Mar 29, 2023

Copy link
Copy Markdown
Contributor Author

@kduret can we fix the build and move forward with this?

Jira ticket is still in "to be groomed" status
(this PR is not mine, it has been migrated from centreon-archive/centreon-archived#12013)

@kduret
kduret requested review from a team, a-launois and wtermellil April 27, 2023 14:46
@a-launois a-launois closed this May 11, 2023
@a-launois

Copy link
Copy Markdown
Contributor

Ticket has been passed as won't be fixed (fixed by another ticket)

@sc979
sc979 deleted the MON-migration-MON-15591-fix_reload_acl_button branch June 15, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants