Skip to content
This repository was archived by the owner on Oct 6, 2023. It is now read-only.

Perlcritic #48

Open
lkappel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Perlcritic #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ebd2be
Variable declared in conditional statement (my $foo = $baz if $bar; …
lkappel Dec 17, 2017
f8527fc
removing unnecessary white characters
lkappel Dec 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions nagios_reader_to_centreon_clapi.pl
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ sub export_resources {
open(my $fh, '<', $OPTION{'config'}."/resource.cfg") or die "Can't open $OPTION{'config'}/resource.cfg: $!";
while (my $line = <$fh>) {
chomp $line;
my ($macro, $value) = split('=', $line, 2) if ($line =~ /=/);
my ($macro, $value);
($macro, $value) = split('=', $line, 2) if ($line =~ /=/);
$macro =~ s/\$//g if defined($macro);
$resource_macros{$macro} = $value if (defined($macro) && defined($value));
}
Expand All @@ -120,7 +121,7 @@ sub export_commands {

foreach my $command (@commands_array) {
next if (!defined($command->{'command_name'}) || $command->{'command_name'} =~ m/bam|check_meta|meta_notify/ || !defined($command->{'command_line'}));

my $command_type = "check";
if ($command->{'command_name'} =~ m/notify/) {
$command_type = "notif";
Expand Down Expand Up @@ -187,7 +188,7 @@ sub export_contacts {
$contact->{'timezone'} =~ s/://g;
push @{$clapi{CONTACT}}, "CONTACT;setparam;".$OPTION{'prefix'}.$contact->{'contact_name'}.";timezone;".$contact->{'timezone'};
}

# Add contact to contactgroups
if (defined($contact->{'contactgroups'})) {
if (ref $contact->{'contactgroups'}) {
Expand Down Expand Up @@ -233,7 +234,7 @@ sub export_contactgroups {
$contacts_exported{$contactgroup->{'members'}} = 1;
}
}

# Loop to add contacts from contact definition
if (defined($contactgroups{$contactgroup->{'contactgroup_name'}} )) {
foreach my $contact (@{$contactgroups{$contactgroup->{'contactgroup_name'}}}) {
Expand Down Expand Up @@ -270,14 +271,13 @@ sub export_hosts {
if ($default_htpl ne "" && $prefix ne "") {
$default_htpl = $prefix.$default_htpl;
}

if (!defined($host->register) || $host->register == 0 || !defined($host->{'address'})) {
$type = "HTPL";
if ($OPTION{'default_htpl'} eq $host->{'host_name'}) {
$default_htpl = "";
}
push @{$clapi{$type}}, "HTPL;ADD;".$prefix.$host->{'host_name'}.";".(defined($host->{'alias'}) ? $host->{'alias'} : $host->{'host_name'}).";;".((@templates) ? join("|", (my @template = map { $OPTION{'prefix'}.$_ } @templates)) : $default_htpl).";;";

} else {
push @{$clapi{$type}}, "HOST;ADD;".$host->{'host_name'}.";".(defined($host->{'alias'}) ? $host->{'alias'} : $host->{'host_name'}).";".$host->{'address'}.";".((@templates) ? join("|", (my @template = map { $OPTION{'prefix'}.$_ } @templates)) : $default_htpl).";".$OPTION{'poller'}.";";
$prefix = "";
Expand Down Expand Up @@ -360,7 +360,7 @@ sub export_hosts {
push @{$clapi{$type}}, $type.";setparent;".$prefix.$host->{'host_name'}.";".$host->{'parents'};
}
}

# Macros handling
foreach my $macro ($host->list_attributes()) {
if ($macro =~ m/^_/ && $macro !~ m/SNMP|HOST_ID/ && defined($host->{$macro})) {
Expand Down Expand Up @@ -400,7 +400,7 @@ sub export_hosts {

# Export Nagios hostgroups using Centreon CLAPI format
sub export_hostgroups {
my @hostgroups_array = @_ ;
my @hostgroups_array = @_ ;

foreach my $hostgroup (@hostgroups_array) {
next if (!defined($hostgroup->{'hostgroup_name'}) || $hostgroup->{'hostgroup_name'} =~ m/centreon\-bam\-contactgroup|\_Module\_BAM/);
Expand Down Expand Up @@ -463,7 +463,7 @@ sub export_services {
if (defined($service->{'use'})) {
export_services($objects->find_object($service->{'use'}, "Nagios::Service"));
}

# Create template of service for services by hostgroups
if (defined($service->{'hostgroup_name'})) {
$service->{'name'} = "Service-By-Hg-".$service->{'service_description'};
Expand Down Expand Up @@ -531,15 +531,15 @@ sub export_services {
if (defined($service->{'icon_image'})) { push @{$clapi{STPL}}, "STPL;setparam;".$OPTION{'prefix'}.$service->{'name'}.";icon_image;".$service->{'icon_image'} };
if (defined($service->{'icon_image_alt'})) { push @{$clapi{STPL}}, "STPL;setparam;".$OPTION{'prefix'}.$service->{'name'}.";icon_image_alt;".$service->{'icon_image_alt'} };
if (defined($service->{'recovery_notification_delay'})) { push @{$clapi{STPL}}, "STPL;setparam;".$OPTION{'prefix'}.$service->{'name'}.";recovery_notification_delay;".$service->{'recovery_notification_delay'} };

# Custom macros handling
foreach my $macro ($service->list_attributes()) {
if ($macro =~ m/^_/ && $macro !~ m/SERVICE_ID/ && defined($service->{$macro})) {
$macro =~ s/_//;
push @{$clapi{STPL}}, "STPL;setmacro;".$OPTION{'prefix'}.$service->{'name'}.";".$macro.";".$service->{"_".$macro}.";0;";
}
}

# Add contactgroups to service
if (defined($service->{'contact_groups'})) {
if (ref $service->{'contact_groups'}) { push @{$clapi{STPL}}, "STPL;setcontactgroup;".$OPTION{'prefix'}.$service->{'name'}.";".(join("|", (my @contactgroups = map { (ref $_ ne "Nagios::ContactGroup") ? $OPTION{'prefix'}.$_ : $OPTION{'prefix'}.$_->{'contactgroup_name'} } @{$service->{'contact_groups'}}))) };
Expand All @@ -557,7 +557,7 @@ sub export_services {
my @hosts;
if (ref $service->{'host_name'}) { @hosts = @{$service->{'host_name'}} };
if (not ref $service->{'host_name'}) { push @hosts, $service->{'host_name'} };

foreach my $host (@hosts) {
if (defined($service->{'service_description'})) { push @{$clapi{SERVICE}}, "SERVICE;ADD;".$host.";".$service->{'service_description'}.";".(defined($service->{'use'}) ? $OPTION{'prefix'}.$service->{'use'} : $default_stpl) };
if (defined($service->{'is_volatile'})) { push @{$clapi{SERVICE}}, "SERVICE;setparam;".$host.";".$service->{'service_description'}.";is_volatile;".$service->{'is_volatile'} };
Expand Down Expand Up @@ -617,7 +617,7 @@ sub export_services {
if (defined($service->{'icon_image'})) { push @{$clapi{SERVICE}}, "SERVICE;setparam;".$host.";".$service->{'service_description'}.";icon_image;".$service->{'icon_image'} };
if (defined($service->{'icon_image_alt'})) { push @{$clapi{SERVICE}}, "SERVICE;setparam;".$host.";".$service->{'service_description'}.";icon_image_alt;".$service->{'icon_image_alt'} };
if (defined($service->{'recovery_notification_delay'})) { push @{$clapi{SERVICE}}, "SERVICE;setparam;".$host.";".$service->{'service_description'}.";recovery_notification_delay;".$service->{'recovery_notification_delay'} };

# Custom macros handling
foreach my $macro ($service->list_attributes()) {
if ($macro =~ m/^_/ && $macro !~ m/SERVICE_ID/ && defined($service->{$macro})) {
Expand All @@ -637,7 +637,7 @@ sub export_services {
if (ref $service->{'contacts'}) { push @{$clapi{SERVICE}}, "SERVICE;setcontact;".$host.";".$service->{'service_description'}.";".(join("|", (my @contactgroups = map { (ref $_ ne "Nagios::Contact") ? $OPTION{'prefix'}.$_ : $OPTION{'prefix'}.$_->{'contact_name'} } @{$service->{'contacts'}}))) };
if (not ref $service->{'contacts'}) { push @{$clapi{SERVICE}}, "SERVICE;setcontact;".$host.";".$service->{'service_description'}.";".$OPTION{'prefix'}.$service->{'contacts'} };
}

# Add service to servicegroups
if (defined($service->{'servicegroups'})) {
if (ref $service->{'servicegroups'}) {
Expand All @@ -650,7 +650,7 @@ sub export_services {
}
}
}

# Deploy services based on previous template on all hosts linked to hostgroup
if (defined($service->{'hostgroup_name'})) {
if (ref $service->{'hostgroup_name'}) {
Expand Down Expand Up @@ -702,9 +702,9 @@ sub export_servicegroups {

foreach my $servicegroup (@servicegroups_array) {
next if (!defined($servicegroup->{'servicegroup_name'}) || $servicegroup->{'servicegroup_name'} =~ m/centreon\-bam\-contactgroup|\_Module\_BAM/);

my (%services_exported, $host_name, $service_description);

push @{$clapi{SG}}, "SG;ADD;".$OPTION{'prefix'}.$servicegroup->{'servicegroup_name'}.";".$servicegroup->{'alias'};
push @{$clapi{SG}}, "SG;setparam;".$OPTION{'prefix'}.$servicegroup->{'servicegroup_name'}.";sg_activate;1";

Expand Down