feat(eslint-config): use @eslintplugin/* packages#1649
Conversation
👷 Deploy request for cedarjs pending review.Visit the deploys page to approve it
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 1s | View ↗ |
nx run-many -t build |
✅ Succeeded | 4m 23s | View ↗ |
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 4m 21s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 15s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-05-20 18:48:59 UTC
@eslintplugin/* packages@eslintplugin/* packages
@eslintplugin/* packages@eslintplugin/* packages
Greptile SummaryThis PR swaps two mature ESLint plugins —
Confidence Score: 3/5This PR replaces two mature, widely-adopted ESLint plugins with pre-alpha (0.0.x) alternatives from a new, unverified npm scope; behavioral equivalence with the originals has not been demonstrated and the removal of axe-core from the a11y plugin's dependency tree is an unverified behavioral change for all downstream Cedar projects. Both replacement packages are at pre-alpha versions from an npm scope with no established provenance, and the PR includes no test output, CI evidence, or eslint --print-config verification showing that plugin:react/recommended, plugin:jsx-a11y/recommended, and the jsx-a11y/aria-role rule resolve correctly with the new packages. The shared eslint-config is consumed by every Cedar project, so a silent runtime failure here would break linting for all downstream users without a clear error trail. packages/eslint-config/package.json — the two aliased plugin entries and the transitive dependency changes (especially axe-core removal) warrant close scrutiny before merging. Important Files Changed
Reviews (5): Last reviewed commit: "feat: use `@eslintplugin/*` packages" | Re-trigger Greptile |
f80fa49 to
bddc991
Compare
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
| "eslint-plugin-jsx-a11y": "npm:@eslintplugin/eslint-plugin-jsx-a11y@0.0.3", | ||
| "eslint-plugin-prettier": "5.5.5", | ||
| "eslint-plugin-react": "7.37.5", | ||
| "eslint-plugin-react": "npm:@eslintplugin/eslint-plugin-react@0.0.1", |
There was a problem hiding this comment.
Plugin API compatibility not verified
The existing ESLint config files make specific API calls that must be present in the replacement packages:
shared.jsextendsplugin:react/recommended— this requires@eslintplugin/eslint-plugin-react@0.0.1to export arecommendedconfig object under itsconfigsproperty.index.jsextendsplugin:jsx-a11y/recommended(whenconfig.web.a11yis enabled) and directly references the rule namejsx-a11y/aria-role.
If either 0.0.x package does not export these config presets or rule names, every downstream Cedar project that runs ESLint will get a hard failure (Definition for rule 'jsx-a11y/aria-role' was not found or Cannot read properties of undefined (reading 'recommended')). The PR doesn't include any test output or CI evidence confirming that eslint --print-config resolves cleanly with these replacements in place.

Switching to more modern, smaller, alternative eslint plugins.
Also see https://github.com/eslint-plugin/eslint-plugins/blob/main/README.md