Lean DRT#158
Merged
Merged
Conversation
Contributor
|
Marking this PR as ready for review since the CI is (finally!) passing |
cdisselkoen
approved these changes
Dec 7, 2023
Co-authored-by: Craig Disselkoen <cdiss@amazon.com>
shaobo-he-aws
approved these changes
Dec 7, 2023
shaobo-he-aws
left a comment
shaobo-he-aws
left a comment
Contributor
There was a problem hiding this comment.
LGTM except for Craig's comments. I agree that we should not be in a rush to remove Dafny.
Contributor
|
Recent commits pull in the change from #166 and address review comments. Please re-review when you get a chance! |
shaobo-he-aws
approved these changes
Dec 7, 2023
shaobo-he-aws
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Included in this PR
lean_impl.rssupports calling the Lean testing harness from RustComing in future PRs
lean_impl.rslean_impl.rsin DRT targets (plus fixes for any issues uncovered by DRT)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.