Skip to content

Add support for TEMPer1F_H1V1.5F#28

Merged
eode merged 1 commit into
ccwienk:masterfrom
urwen:sht20
Sep 20, 2024
Merged

Add support for TEMPer1F_H1V1.5F#28
eode merged 1 commit into
ccwienk:masterfrom
urwen:sht20

Conversation

@urwen

@urwen urwen commented Nov 25, 2023

Copy link
Copy Markdown

Firmware TEMPer1F_H1V1.5F (id 0c45:7402) seems to be using a different temperature sensor (SHT20). This change adds support for this sensor/firmware combination.

@urwen

urwen commented Nov 25, 2023

Copy link
Copy Markdown
Author

BTW, I have rebased all of your changes onto urwen/temper. There is one PR over there you should look at, because I think it's a one-line change to support another version: urwen#29

I want to thank you for forking temper and maintaining it for these past several years. I really appreciate it!!! I've put a note in my README.md to point to this repository, and I'll submit changes here if I add support for more devices.

@ccwienk

ccwienk commented Jan 24, 2024

Copy link
Copy Markdown
Owner

@urwen : npb. however, I think "maintaining" is giving me too much credit. basically, I forked it once to add a fix I needed, and then I actually almost forgot about the fork 🙈

I think I just caused a conflict by admitting another pullrequest that proposed the same change :(

@ccwienk

ccwienk commented Jun 19, 2024

Copy link
Copy Markdown
Owner

@urwen : I made you collaborator

@eode eode merged commit 5438aaa into ccwienk:master Sep 20, 2024
@eode

eode commented Sep 20, 2024

Copy link
Copy Markdown
Collaborator

@ccwienk @urwen I've just merged this branch -- I don't know if you two are active still, but just wanted to let you know.

Should we try to merge these two repos fully, and go with one over the other, going forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants