fix: 修复多语种拼接规则 - #490
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## dev #490 +/- ##
==========================================
+ Coverage 89.97% 90.71% +0.74%
==========================================
Files 107 103 -4
Lines 8288 8658 +370
==========================================
+ Hits 7457 7854 +397
+ Misses 831 804 -27
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
drunkpig
requested changes
Jul 16, 2025
| self._extract_image, | ||
| self._extract_title, self._extract_paragraph]: | ||
| self._extract_title]: | ||
| parsed_html = extract_func(base_url, parsed_html, raw_html) |
Contributor
There was a problem hiding this comment.
此处,几个extractXXX函数应加盖保持一样,即便extract_code, extract_table,目前没有使用language,但是他们实际是接受这个参数的,不能只把extract_paragraph提出来传递,应当一视同仁。
drunkpig
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: