Skip to content

fix: 修复多语种拼接规则 - #490

Merged
drunkpig merged 22 commits into
ccprocessor:devfrom
LollipopsAndWine:dev
Jul 16, 2025
Merged

fix: 修复多语种拼接规则#490
drunkpig merged 22 commits into
ccprocessor:devfrom
LollipopsAndWine:dev

Conversation

@LollipopsAndWine

Copy link
Copy Markdown
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov

codecov Bot commented Jul 15, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
llm_web_kit/extractor/html/extractor.py 90.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #490      +/-   ##
==========================================
+ Coverage   89.97%   90.71%   +0.74%     
==========================================
  Files         107      103       -4     
  Lines        8288     8658     +370     
==========================================
+ Hits         7457     7854     +397     
+ Misses        831      804      -27     
Files with missing lines Coverage Δ
llm_web_kit/extractor/html/recognizer/audio.py 81.81% <100.00%> (ø)
llm_web_kit/extractor/html/recognizer/cccode.py 96.07% <ø> (ø)
llm_web_kit/extractor/html/recognizer/ccmath.py 90.12% <100.00%> (+2.94%) ⬆️
llm_web_kit/extractor/html/recognizer/image.py 92.30% <100.00%> (ø)
llm_web_kit/extractor/html/recognizer/list.py 97.29% <100.00%> (+0.07%) ⬆️
...lm_web_kit/extractor/html/recognizer/recognizer.py 95.16% <100.00%> (-2.34%) ⬇️
llm_web_kit/extractor/html/recognizer/table.py 95.69% <ø> (+0.47%) ⬆️
llm_web_kit/extractor/html/recognizer/text.py 94.47% <100.00%> (+0.10%) ⬆️
llm_web_kit/extractor/html/recognizer/title.py 98.43% <100.00%> (ø)
llm_web_kit/extractor/html/recognizer/video.py 81.81% <100.00%> (ø)
... and 2 more

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread llm_web_kit/extractor/html/extractor.py Outdated
self._extract_image,
self._extract_title, self._extract_paragraph]:
self._extract_title]:
parsed_html = extract_func(base_url, parsed_html, raw_html)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处,几个extractXXX函数应加盖保持一样,即便extract_code, extract_table,目前没有使用language,但是他们实际是接受这个参数的,不能只把extract_paragraph提出来传递,应当一视同仁。

@drunkpig
drunkpig merged commit 3554cdc into ccprocessor:dev Jul 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants