fix(fsm): drop boundary commits that fail on git-ignored cleanrooms#298
Merged
ccisnedev merged 1 commit intoJul 23, 2026
Merged
Conversation
Closes #297. Since 0.20.0 git-ignored the whole cleanrooms/ area, the commit_analysis_boundary (ANALYZE->PLAN) and commit_plan_boundary (->EXECUTE) policies could never run: git refuses to add ignored paths, so the transition failed closed with ERROR_BOUNDARY_COMMIT_FAILED and blocked every cycle at the analysis boundary. A working area that is intentionally ephemeral has no boundary snapshot to commit. - Both transitions are now commit_policy: none; their gates still validate diagnosis.md / plan.md. - The FSM tests ran in a temp repo that did NOT git-ignore cleanrooms/, so the boundary commit succeeded there while failing in every real repo. Tests now assert no commit is made; two obsolete "fails closed when boundary commit fails" tests removed. 591 pass. - Bump 0.21.0 -> 0.21.1. Found by dogfooding a real cycle (cacsi-dev/impulsa #40).
ccisnedev
deleted the
297-fix-fsm-boundary-commits-fail-because-cleanrooms-i
branch
July 23, 2026 00:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297.
Bug
Since 0.20.0 git-ignored the whole
cleanrooms/area, thecommit_analysis_boundary(ANALYZE→PLAN) andcommit_plan_boundary(→EXECUTE) policies could never run —git add -- cleanrooms/<branch>/…refuses ignored paths, so the transition failed closed withERROR_BOUNDARY_COMMIT_FAILED, blocking every cycle at the analysis boundary.Two 0.20.0 decisions contradicted each other: a working area that is intentionally ephemeral (durable artifacts are the issue, code, and tests) has no boundary snapshot to commit.
Fix
complete_analysisandapprove_plan→commit_policy: none. Their gates still validatediagnosis.md/plan.md; only the meaningless commit is gone.cleanrooms/, so the boundary commit succeeded there while failing in every real repo (iq initignores it). Tests now assert no commit is made; two obsolete "fails closed when boundary commit fails" tests removed. 591 pass.Found by dogfooding a real cycle (cacsi-dev/impulsa #40) — the same loop the roadmap's antifragility thesis describes.