Show expected flip duration on Grand Exchange offer tooltips#97
Open
mikeblunts wants to merge 1 commit into
Open
Show expected flip duration on Grand Exchange offer tooltips#97mikeblunts wants to merge 1 commit into
mikeblunts wants to merge 1 commit into
Conversation
Cache the expectedDuration from each suggestion per item name in SuggestionManager and surface it as an "Est. time" line on the GE offer-slot tooltip, beneath the existing Profit line, reusing UIUtilities.formatSuggestionDuration. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaces Copilot's predicted flip duration as an
Est. timeline on the Grand Exchange offer-slot tooltip, right under the existingProfitline.Copilot already returns an
expectedDurationwith each suggestion — it's shown in the side panel ("X profit in 15 min") but nowhere on the GE screen itself. This puts it where you're actually looking: on the offer you're hovering, so you can gauge how long a flip should take without opening the panel.How it works
expectedDurationonly lives on the liveSuggestion, soSuggestionManagernow caches the most recent expected duration per item name as suggestions arrive (cleared onreset()).TooltipControllerlooks it up by item name and appendsEst. time: <formatted>using the existingUIUtilities.formatSuggestionDuration, bumping the tooltip height by one line.No backend changes — the data is already on the client.
Notes / limitations
expectedDurationis available); otherwise the tooltip is unchanged.Est. timecould be shown for any item (not just suggested ones) ifexpectedDurationwere attached to the/pricesresponse — happy to do either.Testing
Built against client 1.12.28 and run locally —
Est. timeshows underProfiton the sell-offer tooltip for suggested items.Two files, ~28 lines:
model/SuggestionManager.java,controller/TooltipController.java.🤖 Generated with Claude Code