Skip to content

Fix an intermittent bootstrap failure after cache purges #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frederikmillingpytlick wants to merge 2 commits into
base: MOODLE_405_STABLE
Choose a base branch
from
Open

Fix an intermittent bootstrap failure after cache purges #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00250bc
Fix issue happening on every consecutive purgecache
frederikmillingpytlick Jun 11, 2026
461720b
Also updated requires to actually point to Moodle 4.5.0
frederikmillingpytlick Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions classes/cache_factory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,21 @@ public function create_config_instance($writer = false) {
}
}

$config = null;

if (!array_key_exists($class, $this->configs)) {
// Create a new instance and call it to load it.
// As part of generating store instance config we test the initialisation of stores.
// Testing this may initialise DI, which will attempt to use cache for hookcallbacks.
// Setting the state to initialising will make it use ad-hoc cache for that request.
self::set_state(self::STATE_INITIALISING);
$this->configs[$class] = new $class;
$this->configs[$class]->load();
$config = new $class();
$config->load();

// Re-register after load in case anything reset $this->configs.
$this->configs[$class] = $config;
} else {
$config = $this->configs[$class];
}

// We need the siteid in order to use the caches, but the siteid
Expand All @@ -77,7 +84,7 @@ public function create_config_instance($writer = false) {
}

// Return the instance.
return $this->configs[$class];
return $config;
}

/**
Expand Down
6 changes: 3 additions & 3 deletions version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@

defined('MOODLE_INTERNAL') || die();

$plugin->version = 2024093000;
$plugin->release = "2024093000";
$plugin->requires = 2024092700; // Requires 4.5.
$plugin->version = 2024093001;
$plugin->release = "2024093001";
$plugin->requires = 2024100700; // Requires 4.5.
$plugin->component = 'tool_forcedcache'; // Full name of the plugin (used for diagnostics).
$plugin->maturity = MATURITY_STABLE;
$plugin->supported = [405, 405];
Expand Down