Preparing comprehensive unit and integration tests#51
Open
reiniervlinschoten wants to merge 26 commits into
Open
Preparing comprehensive unit and integration tests#51reiniervlinschoten wants to merge 26 commits into
reiniervlinschoten wants to merge 26 commits into
Conversation
Fixed conflicts
This was referenced Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request I was working on developing comprehensive unit and integration tests.
For the following tests I have updated the tests:
These functions need updated tests. These test_that files are also marked with TODO:
The following need new unit tests as they are important in getStudyData:
The tests are currently being ran on PythonWrapperTest - Study, which I also use to test the PythonWrapper. Access to the study can be granted by me or @martijnkersloot. No data in this study should be changed or tests will fail. If tests have to write to a database, they can use PythonWrapperTest - Client (Write).