update(command-zod,event-type-zod): make compatible with zod v3/v4 - #200
Closed
oxc wants to merge 1 commit into
Closed
update(command-zod,event-type-zod): make compatible with zod v3/v4#200oxc wants to merge 1 commit into
oxc wants to merge 1 commit into
Conversation
Collaborator
|
now included in #199 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 🦫
This PR adds compatibility with both Zod v3 and Zod v4 to command-zod and event-type-zod. Not all users will be able to upgrade to Zod v4 immediately, so keeping compatibility with both versions is important.
I believe this is the cleanest way to support both versions at the same time, following the instructions from Zod's guide for library authors on "How to support Zod 3 and Zod 4 simultaneously?".
Fixes #197
Important
This change requires a version of Zod >= 3.25.0. Unfortunately, neither v3 nor v4 will compile with the typescript version currently included by castore, so for this PR to work, typescript must be updated as well. Feel free to cherry-pick this change into your mass upgrade PR, or alternatively I can bump typescript in this PR.
Type of change 📝
Please delete options that are not relevant.
How Has This Been Tested? 🧑🔬
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration: 🔧
Checklist: ✅